You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by jl...@apache.org on 2013/03/14 00:57:18 UTC
git commit: refs/heads/master - Summary: Fix exception handling in
security_group.py
Updated Branches:
refs/heads/master a94ff361d -> 381f737e6
Summary: Fix exception handling in security_group.py
Detail: Code was attempting to concatinate an exception to a string.
Updated to convert to text and concatinate that.
BUG-ID: CLOUDSTACK-1052
Bugfix-for: master
Reported-by: Noa Resare
Signed-off-by: John Kinsella <jl...@stratosec.co> 1363218769 -0700
Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/381f737e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/381f737e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/381f737e
Branch: refs/heads/master
Commit: 381f737e64ed9192e6eea4aeffe1920637f7d835
Parents: a94ff36
Author: John Kinsella <jl...@stratosec.co>
Authored: Wed Mar 13 16:52:49 2013 -0700
Committer: John Kinsella <jl...@stratosec.co>
Committed: Wed Mar 13 16:52:49 2013 -0700
----------------------------------------------------------------------
scripts/vm/network/security_group.py | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/381f737e/scripts/vm/network/security_group.py
----------------------------------------------------------------------
diff --git a/scripts/vm/network/security_group.py b/scripts/vm/network/security_group.py
index ed4180a..50a1641 100755
--- a/scripts/vm/network/security_group.py
+++ b/scripts/vm/network/security_group.py
@@ -25,6 +25,8 @@ import os
import xml.dom.minidom
from optparse import OptionParser, OptionGroup, OptParseError, BadOptionError, OptionError, OptionConflictError, OptionValueError
import re
+import traceback
+
iptables = Command("iptables")
bash = Command("/bin/bash")
virsh = Command("virsh")
@@ -692,7 +694,8 @@ def add_network_rules(vm_name, vm_id, vm_ip, signature, seqno, vmMac, rules, vif
return 'true'
except:
- logging.debug("Failed to network rule !: " + sys.exc_type)
+ exceptionText = traceback.format_exc()
+ logging.debug("Failed to network rule !: " + exceptionText)
def getVifs(vmName):
vifs = []