You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/03/18 03:05:23 UTC
[GitHub] [iceberg] rajarshisarkar commented on a change in pull request #4358: AWS: Add TagSession support in AssumeRoleAwsClientFactory
rajarshisarkar commented on a change in pull request #4358:
URL: https://github.com/apache/iceberg/pull/4358#discussion_r829662346
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java
##########
@@ -104,4 +110,11 @@ public void initialize(Map<String, String> properties) {
private String genSessionName() {
return String.format("iceberg-aws-%s", UUID.randomUUID());
}
+
+ private static Set<Tag> toTags(Map<String, String> properties) {
Review comment:
We have a similar method in `AwsProperties`. Can we re-use that?
https://github.com/apache/iceberg/blob/d2bb30f863d7276097c39754b9501ba27403b73c/aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java#L459-L464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org