[GitHub] [helix] jiajunwang commented on a change in pull request #851: Add customized view computation and modify Helix generic controller to include new stage

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #851: Add customized view computation and modify Helix generic controller to include new stage
URL: https://github.com/apache/helix/pull/851#discussion_r388615034
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/common/caches/CustomizedViewCache.java
 ##########
 @@ -139,6 +139,17 @@ private PropertyKey customizedViewKey(PropertyKey.Builder keyBuilder, String res
     return Collections.unmodifiableMap(_customizedViewMap);
   }
 
+  /**
+   * Remove dead customized views from map
+   * @param resourceNames
+   */
+
+  public void removeCustomizedView(List<String> resourceNames) {
 
 Review comment:
   Do you think we need sync control on all the map operations here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org