You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/22 16:00:25 UTC
[GitHub] [superset] nytai opened a new pull request #13283: fix(menu): links that result in 404s
nytai opened a new pull request #13283:
URL: https://github.com/apache/superset/pull/13283
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
https://github.com/apache/superset/pull/13087 made some change to the menu links, trying to standardize routes to always end in an `/`, which should make matching between frontend routes and backend routes easier. When a route is `@expose`d, and ends in a `/`, flask automatically redirects urls that do not end in a `/` to the correct endpoint. This behavior does not happen when the route is `@expose`d without the trailing `/`. It looks like FAB `@expose`s most endpoints to end in a `/`, except for the `/form` route, which has resulted in some 404s for the menu links. This PR addresses the issue by changing the `@expose`d routes to end in a `/`, except for the case of the FAB `form` route, where this is not possible, the trailing `/` is removed from the menu links.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
- Menu link for `/csvtodatabaseview/form` does not 404
- Menu link for `/exceltodatabaseview/form` does not 404
- Menu link for `/superset/import_dashboards/` does not 404
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13283: fix(menu): links that result in 404s
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13283:
URL: https://github.com/apache/superset/pull/13283#issuecomment-783558598
# [Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=h1) Report
> Merging [#13283](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=desc) (27193ab) into [master](https://codecov.io/gh/apache/superset/commit/b5379bc8c5312c266f777452967abfc6cb9354f8?el=desc) (b5379bc) will **decrease** coverage by `5.51%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13283 +/- ##
==========================================
- Coverage 77.19% 71.68% -5.52%
==========================================
Files 864 776 -88
Lines 44921 40265 -4656
Branches 5403 4123 -1280
==========================================
- Hits 34677 28864 -5813
- Misses 10121 11401 +1280
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.44% <ø> (-0.11%)` | :arrow_down: |
| javascript | `?` | |
| python | `80.39% <100.00%> (-0.43%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.36% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.37% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [437 more](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=footer). Last update [b5379bc...27193ab](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13283: fix(menu): links that result in 404s
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13283:
URL: https://github.com/apache/superset/pull/13283#issuecomment-783558598
# [Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=h1) Report
> Merging [#13283](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=desc) (27193ab) into [master](https://codecov.io/gh/apache/superset/commit/b5379bc8c5312c266f777452967abfc6cb9354f8?el=desc) (b5379bc) will **increase** coverage by `3.15%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13283 +/- ##
==========================================
+ Coverage 77.19% 80.35% +3.15%
==========================================
Files 864 298 -566
Lines 44921 24283 -20638
Branches 5403 0 -5403
==========================================
- Hits 34677 19512 -15165
+ Misses 10121 4771 -5350
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `80.35% <100.00%> (-0.47%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.36% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <100.00%> (-0.45%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.73% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <0.00%> (-0.49%)` | :arrow_down: |
| ... and [567 more](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=footer). Last update [b5379bc...27193ab](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #13283: fix(menu): links that result in 404s
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #13283:
URL: https://github.com/apache/superset/pull/13283#issuecomment-783558598
# [Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=h1) Report
> Merging [#13283](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=desc) (27193ab) into [master](https://codecov.io/gh/apache/superset/commit/b5379bc8c5312c266f777452967abfc6cb9354f8?el=desc) (b5379bc) will **increase** coverage by `2.73%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13283 +/- ##
==========================================
+ Coverage 77.19% 79.92% +2.73%
==========================================
Files 864 298 -566
Lines 44921 24255 -20666
Branches 5403 0 -5403
==========================================
- Hits 34677 19387 -15290
+ Misses 10121 4868 -5253
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `79.92% <100.00%> (-0.90%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.36% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.92% <100.00%> (-0.45%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `60.34% <0.00%> (-22.42%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [588 more](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=footer). Last update [b5379bc...27193ab](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13283: fix(menu): links that result in 404s
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13283:
URL: https://github.com/apache/superset/pull/13283#issuecomment-783558598
# [Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=h1) Report
> Merging [#13283](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=desc) (27193ab) into [master](https://codecov.io/gh/apache/superset/commit/b5379bc8c5312c266f777452967abfc6cb9354f8?el=desc) (b5379bc) will **decrease** coverage by `5.35%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13283 +/- ##
==========================================
- Coverage 77.19% 71.84% -5.36%
==========================================
Files 864 776 -88
Lines 44921 40265 -4656
Branches 5403 4123 -1280
==========================================
- Hits 34677 28928 -5749
- Misses 10121 11337 +1216
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.84% <ø> (+0.29%)` | :arrow_up: |
| javascript | `?` | |
| python | `80.39% <100.00%> (-0.43%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/app.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.36% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.37% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [437 more](https://codecov.io/gh/apache/superset/pull/13283/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=footer). Last update [b5379bc...27193ab](https://codecov.io/gh/apache/superset/pull/13283?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai merged pull request #13283: fix(menu): links that result in 404s
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #13283:
URL: https://github.com/apache/superset/pull/13283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13283: fix(menu): links that result in 404s
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13283:
URL: https://github.com/apache/superset/pull/13283#issuecomment-783558598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michellethomas commented on pull request #13283: fix(menu): links that result in 404s
Posted by GitBox <gi...@apache.org>.
michellethomas commented on pull request #13283:
URL: https://github.com/apache/superset/pull/13283#issuecomment-783567808
Thanks!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org