[GitHub] [airflow] jedcunningham commented on a change in pull request #16784: Chart: warn when using default logging with KubernetesExecutor

[GitBox <gi...@apache.org>]

jedcunningham commented on a change in pull request #16784:
URL: https://github.com/apache/airflow/pull/16784#discussion_r663271334



##########
File path: chart/templates/NOTES.txt
##########
@@ -66,6 +66,16 @@ You can get Fernet Key value by running the following:
 
 {{- end }}
 
+{{- if or (eq .Values.executor "KubernetesExecutor") (eq .Values.executor "CeleryKubernetesExecutor") }}
+{{- if and (not .Values.logs.persistence.enabled) (eq (lower (tpl .Values.config.logging.remote_logging .)) "false") }}

Review comment:
       Correct. I considered looking at `env`, but nothing we can really do for `extraEnvFrom` or if its baked into the image so I figured 🤷‍♂️.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org