You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@toree.apache.org by lresende <gi...@git.apache.org> on 2017/03/22 18:27:22 UTC

[GitHub] incubator-toree pull request #117: [TOREE-397] Avoid hardcoding the deploy m...

GitHub user lresende opened a pull request:

    https://github.com/apache/incubator-toree/pull/117

    [TOREE-397] Avoid hardcoding the deploy mode property

    By checking if a proper spark.submit.deployMode property
    is available in the sparkConf enables choosing the deploy
    mode by using system properties such as $SPARK_OPTS.
    
    This change continues to use client mode if no configuration
    was provided.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lresende/incubator-toree toree-397

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-toree/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
    
----
commit fd887d80fd4241ea3be77699d27227287f366a95
Author: Luciano Resende <lr...@apache.org>
Date:   2017-03-22T18:26:26Z

    [TOREE-397] Avoid hardcoding the deploy mode property
    
    By checking if a proper spark.submit.deployMode property
    is available in the sparkConf enables choosing the deploy
    mode by using system properties such as $SPARK_OPTS.
    
    This change continues to use client mode if no configuration
    was provided.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-toree pull request #117: [TOREE-397] Avoid hardcoding the deploy m...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-toree/pull/117


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---