You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Anoop Sam John (Jira)" <ji...@apache.org> on 2020/07/08 13:44:00 UTC
[jira] [Created] (HBASE-24695) FSHLog - close the current WAL file
in a background thread
Anoop Sam John created HBASE-24695:
--------------------------------------
Summary: FSHLog - close the current WAL file in a background thread
Key: HBASE-24695
URL: https://issues.apache.org/jira/browse/HBASE-24695
Project: HBase
Issue Type: Improvement
Reporter: Anoop Sam John
Assignee: Anoop Sam John
We have this as a TODO in code already
{code}
// It is at the safe point. Swap out writer from under the blocked writer thread.
// TODO: This is close is inline with critical section. Should happen in background?
if (this.writer != null) {
oldFileLen = this.writer.getLength();
try {
TraceUtil.addTimelineAnnotation("closing writer");
this.writer.close();
TraceUtil.addTimelineAnnotation("writer closed");
this.closeErrorCount.set(0);
}
{code}
This close call in critical section and writes are blocked. Lets move this close call into another WALCloser thread.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)