You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/11/02 19:58:03 UTC
Re: Review Request 39634: FreeBSD: Enable mesos build and start
fixing some tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/#review104756
-----------------------------------------------------------
configure.ac (lines 612 - 621)
<https://reviews.apache.org/r/39634/#comment162999>
If it's not too much trouble, it would be great to see this logic added also the `cmake/CompilationCOnfigure.cmake`. It should only be a couple lines of code.
- Alex Clemmer
On Oct. 30, 2015, 5:05 a.m., David Forsythe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39634/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 5:05 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-1563
> https://issues.apache.org/jira/browse/MESOS-1563
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FreeBSD: Enable mesos build and start fixing some tests
>
>
> Diffs
> -----
>
> configure.ac 656766430e2720c6a407e282521102b54547fd2d
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3
> src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697
> src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8
>
> Diff: https://reviews.apache.org/r/39634/diff/
>
>
> Testing
> -------
>
> make check on ubuntu 14.04
>
>
> Thanks,
>
> David Forsythe
>
>
Re: Review Request 39634: FreeBSD: Enable mesos build and start
fixing some tests
Posted by David Forsythe <df...@gmail.com>.
> On Nov. 2, 2015, 6:58 p.m., Alex Clemmer wrote:
> > configure.ac, lines 612-621
> > <https://reviews.apache.org/r/39634/diff/2/?file=1112829#file1112829line612>
> >
> > If it's not too much trouble, it would be great to see this logic added also the `cmake/CompilationCOnfigure.cmake`. It should only be a couple lines of code.
Mind if that happens after/if this change lands? I'm not sure what the ettiquite is for filing tickets on unsupported platforms, but I have no problem bringing the cmake stuff up to date if this gets merged.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/#review104756
-----------------------------------------------------------
On Oct. 30, 2015, 5:05 a.m., David Forsythe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39634/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 5:05 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-1563
> https://issues.apache.org/jira/browse/MESOS-1563
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FreeBSD: Enable mesos build and start fixing some tests
>
>
> Diffs
> -----
>
> configure.ac 656766430e2720c6a407e282521102b54547fd2d
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3
> src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697
> src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8
>
> Diff: https://reviews.apache.org/r/39634/diff/
>
>
> Testing
> -------
>
> make check on ubuntu 14.04
>
>
> Thanks,
>
> David Forsythe
>
>
Re: Review Request 39634: FreeBSD: Enable mesos build and start
fixing some tests
Posted by Alex Clemmer <cl...@gmail.com>.
> On Nov. 2, 2015, 6:58 p.m., Alex Clemmer wrote:
> > configure.ac, lines 612-621
> > <https://reviews.apache.org/r/39634/diff/2/?file=1112829#file1112829line612>
> >
> > If it's not too much trouble, it would be great to see this logic added also the `cmake/CompilationCOnfigure.cmake`. It should only be a couple lines of code.
>
> David Forsythe wrote:
> Mind if that happens after/if this change lands? I'm not sure what the ettiquite is for filing tickets on unsupported platforms, but I have no problem bringing the cmake stuff up to date if this gets merged.
Sure, that sounds good, but could I ask you file a JIRA ticket so we can track the work? The CMake epic is here: https://issues.apache.org/jira/browse/MESOS-898
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/#review104756
-----------------------------------------------------------
On Oct. 30, 2015, 5:05 a.m., David Forsythe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39634/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 5:05 a.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-1563
> https://issues.apache.org/jira/browse/MESOS-1563
>
>
> Repository: mesos
>
>
> Description
> -------
>
> FreeBSD: Enable mesos build and start fixing some tests
>
>
> Diffs
> -----
>
> configure.ac 656766430e2720c6a407e282521102b54547fd2d
> src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db
> src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3
> src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697
> src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8
>
> Diff: https://reviews.apache.org/r/39634/diff/
>
>
> Testing
> -------
>
> make check on ubuntu 14.04
>
>
> Thanks,
>
> David Forsythe
>
>