You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/06 02:48:49 UTC

[GitHub] [pulsar] liangyepianzhou opened a new pull request, #18749: [Branch-2.10][Broker] Make PersistentTopicsBase#internalGetPartitionedMetadata async

liangyepianzhou opened a new pull request, #18749:
URL: https://github.com/apache/pulsar/pull/18749

   ### Motivation&Modifications
   Cherry-pick https://github.com/liangyepianzhou/pulsar/pull/15
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou commented on pull request #18749: [Branch-2.10][Broker] Make PersistentTopicsBase#internalGetPartitionedMetadata async

Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on PR #18749:
URL: https://github.com/apache/pulsar/pull/18749#issuecomment-1338684129

   >You've got to write the motivation to describe why we need to cherry-pick this PR. :)
   @mattisonchao Thanks for your point out. This PR needs to release on 2.10.3, so we need to cherry-pick it to branch-2.10.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] liangyepianzhou merged pull request #18749: [cherry-pick][branch-2.10] Make PersistentTopicsBase#internalGetPartitionedMetadata async

Posted by GitBox <gi...@apache.org>.
liangyepianzhou merged PR #18749:
URL: https://github.com/apache/pulsar/pull/18749


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on pull request #18749: [Branch-2.10][Broker] Make PersistentTopicsBase#internalGetPartitionedMetadata async

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #18749:
URL: https://github.com/apache/pulsar/pull/18749#issuecomment-1338677668

   You've got to write the motivation to describe why we need to cherry-pick this PR. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org