You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bb...@apache.org on 2018/10/19 07:27:07 UTC
[mesos] 03/03: Enabled more constructors for master
`RegistryOperation`.
This is an automated email from the ASF dual-hosted git repository.
bbannier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 790a04abc6521f003b07ee4882100ede1eec14d2
Author: Benjamin Bannier <be...@mesosphere.io>
AuthorDate: Thu Oct 18 09:33:39 2018 +0200
Enabled more constructors for master `RegistryOperation`.
Since this class was explicitly declaring a constructor, no other
constructors such as copy or move constructors were generated.
This patch removes the custom constructor so all default constructors
are generated automatically. This e.g., enables move construction of
`RegistryOperation` values.
Review: https://reviews.apache.org/r/69042/
---
src/master/registrar.hpp | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/master/registrar.hpp b/src/master/registrar.hpp
index 4f7c7ce..b5aa47f 100644
--- a/src/master/registrar.hpp
+++ b/src/master/registrar.hpp
@@ -45,9 +45,6 @@ class RegistrarProcess;
class RegistryOperation : public process::Promise<bool>
{
public:
- RegistryOperation() : success(false) {}
- ~RegistryOperation() override {}
-
// Attempts to invoke the operation on the registry object.
// Aided by accumulator(s):
// slaveIDs - is the set of registered slaves.
@@ -70,7 +67,7 @@ protected:
virtual Try<bool> perform(Registry* registry, hashset<SlaveID>* slaveIDs) = 0;
private:
- bool success;
+ bool success = false;
};