You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/06 09:23:28 UTC
[GitHub] [apisix-ingress-controller] lingsamuel opened a new pull request, #1133: chore: make api version const consistent
lingsamuel opened a new pull request, #1133:
URL: https://github.com/apache/apisix-ingress-controller/pull/1133
Signed-off-by: Ling Samuel <li...@gmail.com>
### Type of change:
- [ ] New feature provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1133: chore: make api version const consistent
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1133:
URL: https://github.com/apache/apisix-ingress-controller/pull/1133#discussion_r915580337
##########
test/e2e/suite-ingress/suite-ingress-features/resourcesync.go:
##########
@@ -20,10 +20,10 @@ import (
"net/http"
"time"
+ "github.com/apache/apisix-ingress-controller/pkg/id"
ginkgo "github.com/onsi/ginkgo/v2"
"github.com/stretchr/testify/assert"
- "github.com/apache/apisix-ingress-controller/pkg/id"
Review Comment:
test/e2e has its own separate go mod, so for it `apache/apisix-ingress-controller` is a 3rd party module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel merged pull request #1133: chore: make api version const consistent
Posted by GitBox <gi...@apache.org>.
lingsamuel merged PR #1133:
URL: https://github.com/apache/apisix-ingress-controller/pull/1133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] spacewander commented on a diff in pull request #1133: chore: make api version const consistent
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #1133:
URL: https://github.com/apache/apisix-ingress-controller/pull/1133#discussion_r915576025
##########
test/e2e/suite-ingress/suite-ingress-features/resourcesync.go:
##########
@@ -20,10 +20,10 @@ import (
"net/http"
"time"
+ "github.com/apache/apisix-ingress-controller/pkg/id"
ginkgo "github.com/onsi/ginkgo/v2"
"github.com/stretchr/testify/assert"
- "github.com/apache/apisix-ingress-controller/pkg/id"
Review Comment:
We don't need to modify this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org