You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/13 13:01:02 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6424: arm/tlsr82: bugfix, tlsr82_flash_ioctl() return wrong value.

xiaoxiang781216 commented on code in PR #6424:
URL: https://github.com/apache/incubator-nuttx/pull/6424#discussion_r895689135


##########
arch/arm/src/tlsr82/tlsr82_flash_mtd.c:
##########
@@ -775,6 +806,7 @@ static int tlsr82_flash_ioctl(struct mtd_dev_s *dev, int cmd,
           /* Ignore arg, direct protect full chip */
 
           tlsr82_flash_protect();
+          ret = OK;

Review Comment:
   let's init ret = OK instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org