[GitHub] [pulsar] merlimat commented on a change in pull request #4122: Improve tests for ReaderImpl and ManagedLedgerImpl

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #4122: Improve tests for ReaderImpl and ManagedLedgerImpl
URL: https://github.com/apache/pulsar/pull/4122#discussion_r278228231
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/TopicReaderTest.java
 ##########
 @@ -554,7 +563,7 @@ public void testReaderIsAbleToSeekWithTimeOnBeginningOfTopic() throws Exception
         producer.close();
     }
 
-    @Test
+    @Test(timeOut = 5000)
 
 Review comment:
   5seconds may seem a long time, but on the Apache Jenkins could be very little time :) 
   
   BTW: there's already a default timeout on tests set on the testng config (I think it's 120 secs), to cover for stuck tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services