You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by wuchong <gi...@git.apache.org> on 2016/08/24 03:06:14 UTC
[GitHub] flink pull request #2411: [FLINK-4453] [docs] Scala code example in Window d...
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/2411
[FLINK-4453] [docs] Scala code example in Window documentation shows Java
quick fix... \U0001f604
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink window-doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2411.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2411
----
commit e72d1a09679331f760807360e754a2aec290d97c
Author: Jark Wu <wu...@alibaba-inc.com>
Date: 2016-08-24T03:04:25Z
[FLINK-4453] [docs] Scala code example in Window documentation shows Java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2411: [FLINK-4453] [docs] Scala code example in Window document...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2411
Hi @fhueske , it seems that a Scala version of WindowFunction does exist, which is `org.apache.flink.streaming.api.scala.function.WindowFunction`. And both Scala WindowedStream and AllWindowedStream only accept the Scala version of WindowFunction. The difference between Scala and Java version is that the `input` parameter is a Scala Iterable and a Java Iterable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2411: [FLINK-4453] [docs] Scala code example in Window d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2411
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2411: [FLINK-4453] [docs] Scala code example in Window document...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2411
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2411: [FLINK-4453] [docs] Scala code example in Window document...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2411
Ah, OK. Didn't know that. Thanks! :-)
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2411: [FLINK-4453] [docs] Scala code example in Window document...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2411
Thanks for the quick fix, @wuchong!
The change looks good, but I just realized that the Java code might be on purpose in the Scala tab. It shows the interface of the `WindowFunction` which is defined in Java and the same interface is used by the Scala API. So not sure if we should translate the code to Scala because a Scala version of the interface does not exist.
Maybe adding a comment that the Scala API uses Java interfaces is better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---