You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Gary Dusbabek (JIRA)" <ji...@apache.org> on 2010/12/28 00:32:45 UTC
[jira] Created: (CASSANDRA-1909) normal replication shouldn't
happen on counter CFs.
normal replication shouldn't happen on counter CFs.
---------------------------------------------------
Key: CASSANDRA-1909
URL: https://issues.apache.org/jira/browse/CASSANDRA-1909
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Gary Dusbabek
Assignee: Kelvin Kakugawa
Fix For: 0.8
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1909) normal replication shouldn't
happen on counter CFs.
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976727#action_12976727 ]
Sylvain Lebresne commented on CASSANDRA-1909:
---------------------------------------------
For counters, normal replication doesn't work because the counter logic requires that we first insert the update to a first, master, replica, before attempting any replication of this update (involving a read in particular). So, unless I've missed something in the last 2 weeks, the choice for counters is either R.O.W or no replication (in which case, you'll only replicate on read repair or run-of-the-mill repair).
In #1546, I proposed a slightly different approach where we kinda do the repair-on-write as part of the write (for now I refer you to the patch of #1546 for the details). The obvious drawback is that you'll add a read to the read path. BUT, not only can it be kept optional as R.O.W is, but more importantly it allows to restore a good part of the usual consistency level guarantees (I say 'good part' because it still doesn't solve the problem of failed update that you don't know if you should replay or not). And it's easy to make CL.ONE not wait on the replication (and thus the read), so we would still have something along the line of what the current R.O.W does.
Anyway, all this jibber jabber to say that I plan to work on this pretty soon, and if nobody is opposed to my idea (?), this may supersed this issue.
> normal replication shouldn't happen on counter CFs.
> ---------------------------------------------------
>
> Key: CASSANDRA-1909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1909
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Kelvin Kakugawa
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1909) normal replication shouldn't
happen on counter CFs.
Posted by "Kelvin Kakugawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975386#action_12975386 ]
Kelvin Kakugawa commented on CASSANDRA-1909:
--------------------------------------------
read repair is allowed for counter CFs, as well. However, using both replicate-on-write and read repair may be excessive. I'd recommend defaulting to read repair, unless you require stronger consistency for a read penalty on write.
> normal replication shouldn't happen on counter CFs.
> ---------------------------------------------------
>
> Key: CASSANDRA-1909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1909
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Kelvin Kakugawa
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1909) normal replication shouldn't
happen on counter CFs.
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975382#action_12975382 ]
Gary Dusbabek commented on CASSANDRA-1909:
------------------------------------------
One easy optimization that could be made with this patch would be to put the logic for both counter-CF and non-counter-CFs in SP.mutate. That way we'd not be filling up the REPLICATE_ON_WRITE stage with a bunch of no-ops for the non-counter-CF writes.
> normal replication shouldn't happen on counter CFs.
> ---------------------------------------------------
>
> Key: CASSANDRA-1909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1909
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Kelvin Kakugawa
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1909) normal replication shouldn't
happen on counter CFs.
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975833#action_12975833 ]
Gary Dusbabek commented on CASSANDRA-1909:
------------------------------------------
It took me a while to realize that replicate-on-write and counters were orthogonal concepts. Knowing that puts this ticket in a different light since it seems that you can have counters that don't use replicate-on-write, in which case you'd want to rely on normal replication. But then how is a counter that doesn't use replicate-on-write useful? The example conf doesn't use it.
Either way in the default case (ROW is not being used), we send a ROWTask to the ROW-Stage for every RowMutation that ends up being mostly busy-work (it exits as soon as it realizes it's dealing with a non-ROW CF). There ought to be a way to improve that so as not to penalize normal writes.
> normal replication shouldn't happen on counter CFs.
> ---------------------------------------------------
>
> Key: CASSANDRA-1909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1909
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Kelvin Kakugawa
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1909) normal replication shouldn't
happen on counter CFs.
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976733#action_12976733 ]
Gary Dusbabek commented on CASSANDRA-1909:
------------------------------------------
Thanks Sylvain. No opposition from me.
> normal replication shouldn't happen on counter CFs.
> ---------------------------------------------------
>
> Key: CASSANDRA-1909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1909
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Kelvin Kakugawa
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CASSANDRA-1909) normal replication shouldn't
happen on counter CFs.
Posted by "Kelvin Kakugawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Kakugawa reopened CASSANDRA-1909:
----------------------------------------
Actually, let's discuss this first.
> normal replication shouldn't happen on counter CFs.
> ---------------------------------------------------
>
> Key: CASSANDRA-1909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1909
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Kelvin Kakugawa
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1909) normal replication shouldn't
happen on counter CFs.
Posted by "Kelvin Kakugawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Kakugawa resolved CASSANDRA-1909.
----------------------------------------
Resolution: Not A Problem
> normal replication shouldn't happen on counter CFs.
> ---------------------------------------------------
>
> Key: CASSANDRA-1909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1909
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Kelvin Kakugawa
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1909) normal replication shouldn't
happen on counter CFs.
Posted by "Kelvin Kakugawa (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Kakugawa resolved CASSANDRA-1909.
----------------------------------------
Resolution: Not A Problem
> normal replication shouldn't happen on counter CFs.
> ---------------------------------------------------
>
> Key: CASSANDRA-1909
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1909
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Gary Dusbabek
> Assignee: Kelvin Kakugawa
> Fix For: 0.8
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.