You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2022/06/23 09:42:46 UTC

[GitHub] [brooklyn-ui] ahgittin opened a new pull request, #338: Improve handling of spec types in composer

ahgittin opened a new pull request, #338:
URL: https://github.com/apache/brooklyn-ui/pull/338

   Previously we used regex on key names to determine if the contents was an entity spec.  This meant some (eg multi-group) didn't work and in some cases could make the UI unusable or broken.
   
   This checks the actual type defined for the key name and of the value if the type is Object and so supports entity spec
   
   either if:
   - it uses the DSL word
   - the key type matches
   - the key name matches (fallback for where type is unknown/not-loaded and value not set)
   
   and in multiple places:
   - in model
   - in designer view canvas
   - in spec editor
   
   Also makes minor related improvements to UI and code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [brooklyn-ui] algairim merged pull request #338: Improve handling of spec types in composer

Posted by GitBox <gi...@apache.org>.
algairim merged PR #338:
URL: https://github.com/apache/brooklyn-ui/pull/338


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [brooklyn-ui] ahgittin commented on pull request #338: Improve handling of spec types in composer

Posted by GitBox <gi...@apache.org>.
ahgittin commented on PR #338:
URL: https://github.com/apache/brooklyn-ui/pull/338#issuecomment-1164193029

   Includes and builds on https://github.com/apache/brooklyn-ui/pull/332


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org