You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "fdaugan (via GitHub)" <gi...@apache.org> on 2023/08/17 19:20:14 UTC
[GitHub] [httpcomponents-core] fdaugan opened a new pull request, #415: Remove useless ParseException from signature
fdaugan opened a new pull request, #415:
URL: https://github.com/apache/httpcomponents-core/pull/415
ParseException can be removed from all signatures of this class. And since this class is final, there is no risk of overridden signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] fdaugan closed pull request #415: Remove useless ParseException from signatures in EntityUtils
Posted by "fdaugan (via GitHub)" <gi...@apache.org>.
fdaugan closed pull request #415: Remove useless ParseException from signatures in EntityUtils
URL: https://github.com/apache/httpcomponents-core/pull/415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on pull request #415: Remove useless ParseException from signatures in EntityUtils
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #415:
URL: https://github.com/apache/httpcomponents-core/pull/415#issuecomment-1684011715
Changing exceptions in method signatures does not break binary compatibility. It would break source compatibility though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #415: Remove useless ParseException from signatures in EntityUtils
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #415:
URL: https://github.com/apache/httpcomponents-core/pull/415#issuecomment-1684000739
@fdaugan We cannot do that. It would break the binary compatibility with previous releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] fdaugan commented on pull request #415: Remove useless ParseException from signatures in EntityUtils
Posted by "fdaugan (via GitHub)" <gi...@apache.org>.
fdaugan commented on PR #415:
URL: https://github.com/apache/httpcomponents-core/pull/415#issuecomment-1684003051
Indeed, I have just seen that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org