You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by apiri <gi...@git.apache.org> on 2016/04/05 03:01:14 UTC

[GitHub] nifi pull request: NIFI-1689 ListFile test inconsistent on various...

GitHub user apiri opened a pull request:

    https://github.com/apache/nifi/pull/326

    NIFI-1689 ListFile test inconsistent on various environments 

    NIFI-1689 Correcting TimeUnit conversion to be milliseconds instead of the incorrect microseconds and using historical modified times to avoid issues with second granularity of HFS+

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apiri/incubator-nifi NIFI-1689

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/326.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #326
    
----
commit 2bd32cb1bffe651e14ef7b3a53f30589342f8617
Author: Aldrin Piri <al...@apache.org>
Date:   2016-04-04T20:01:16Z

    NIFI-1689 Correcting TimeUnit conversion to be milliseconds instead of the incorrect microseconds and using historical modified times to avoid issues with second granularity of HFS+

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] nifi pull request: NIFI-1689 ListFile test inconsistent on various...

Posted by Tony Kurc <tr...@gmail.com>.
As was I, but I can't test tonight
On Apr 4, 2016 9:54 PM, "alopresto" <gi...@git.apache.org> wrote:

> Github user alopresto commented on the pull request:
>
>     https://github.com/apache/nifi/pull/326#issuecomment-205592813
>
>     I was one of the people having issues with `TestListFile` on the 0.6.0
> build, but I rebooted my machine during an OS patch between then and now.
> As of right now, I can no longer reproduce the test errors prior to
> applying this patch for verification. I have heard the same from other
> people in similar situations.
>
>     However, reviewing the code, the changes make sense and I believe this
> should solve the problem for Mac OS X users.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] nifi pull request: NIFI-1689 ListFile test inconsistent on various...

Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the pull request:

    https://github.com/apache/nifi/pull/326#issuecomment-205592813
  
    I was one of the people having issues with `TestListFile` on the 0.6.0 build, but I rebooted my machine during an OS patch between then and now. As of right now, I can no longer reproduce the test errors prior to applying this patch for verification. I have heard the same from other people in similar situations. 
    
    However, reviewing the code, the changes make sense and I believe this should solve the problem for Mac OS X users. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1689 ListFile test inconsistent on various...

Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:

    https://github.com/apache/nifi/pull/326#issuecomment-205818958
  
    Closing as it has been merged into the 0.6-support, 0.x and master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1689 ListFile test inconsistent on various...

Posted by apiri <gi...@git.apache.org>.
Github user apiri closed the pull request at:

    https://github.com/apache/nifi/pull/326


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request: NIFI-1689 ListFile test inconsistent on various...

Posted by apiri <gi...@git.apache.org>.
Github user apiri commented on the pull request:

    https://github.com/apache/nifi/pull/326#issuecomment-205645456
  
    Tested on a variety of platforms:
    
    - OS X 10.11 - JDK 8u77 - Maven 3.3.9
    - Windows 7 - JDK 7u79 - Maven 3.3.9
    - Windows 10 (VM) - JDK 8u51 - Maven 3.3.3
    - CentOS 7 - OpenJDK 7u95 - Maven 3.3.1
    - Travis CI - Debian Precise - Oracle JDK 7 & 8, OpenJDK 7 - Maven 3.2.5 https://travis-ci.org/apache/nifi/builds/120781483
    
    Windows platforms were tested via application to a branch with the efforts of #325 also included as these were previously causing issues prevening the full test suite from executing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---