You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2017/12/08 22:25:36 UTC

[GitHub] spark pull request #19930: [SPARK-22279][SQL][FOLLOWUP] Preserve a test case...

GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/19930

    [SPARK-22279][SQL][FOLLOWUP] Preserve a test case assumping convertMetastore=false

    ## What changes were proposed in this pull request?
    
    This fixes a test case to preserve the assumption `convertMetastoreOrc=false`.
    
    ## How was this patch tested?
    
    Pass the Jenkins.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-22279-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19930
    
----
commit 244981250ecfed35c53db96740284bcdb83fa0db
Author: Dongjoon Hyun <do...@apache.org>
Date:   2017-12-08T22:17:48Z

    [SPARK-22279][SQL][FOLLOWUP] Preserve a test case assumping convertMetastoreOrc=true

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19930: [SPARK-22279][SQL][FOLLOWUP] Preserve a test case assump...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19930
  
    **[Test build #84662 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84662/testReport)** for PR 19930 at commit [`2449812`](https://github.com/apache/spark/commit/244981250ecfed35c53db96740284bcdb83fa0db).
     * This patch **fails PySpark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19930: [SPARK-22279][SQL][FOLLOWUP] Preserve a test case...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun closed the pull request at:

    https://github.com/apache/spark/pull/19930


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19930: [SPARK-22279][SQL][FOLLOWUP] Preserve a test case...

Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19930#discussion_r155891082
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala ---
    @@ -96,8 +97,10 @@ class HiveOrcSourceSuite extends OrcSuite with TestHiveSingleton {
                |STORED AS orc
                |LOCATION '$uri'""".stripMargin)
           val result = Row("a", "b         ", "c", Seq("d  "))
    -      checkAnswer(spark.table("hive_orc"), result)
    -      checkAnswer(spark.table("spark_orc"), result)
    +      withSQLConf(HiveUtils.CONVERT_METASTORE_ORC.key -> "false") {
    --- End diff --
    
    Sorry, @gatorsmile . I missed that this test case assumes that `convertMetastoreOrc=false`.
    It's my bad. Actually, I had a patch to support `CHAR` in `convertMetastoreOrc` internally, so I was confused.
    
    I'm investigating the root cause why we missed this. There seems to be some interference between test suites about SQLConf. So far, I found the test passed strangely like the following.
    ```
    build/sbt -Phive "project hive" "test-only *.HiveOrcFilterSuite *.HiveOrcSourceSuite"
    ```
    But, this fails when we do this alone.
    ```
    build/sbt -Phive "project hive" "test-only *.HiveOrcSourceSuite"
    ```
    
    First of all, I'll try to find the root case among test suites. Then, I'll make the ORC CHAR patch later.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19930: [SPARK-22279][SQL][FOLLOWUP] Preserve a test case assump...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19930
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19930: [SPARK-22279][SQL][FOLLOWUP] Preserve a test case assump...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19930
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84662/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19930: [SPARK-22279][SQL][FOLLOWUP] Preserve a test case assump...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19930
  
    **[Test build #84662 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84662/testReport)** for PR 19930 at commit [`2449812`](https://github.com/apache/spark/commit/244981250ecfed35c53db96740284bcdb83fa0db).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org