You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Scott Gray <le...@gmail.com> on 2008/06/13 07:02:33 UTC
Re: svn commit: r667333 - /ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy
Hi Hans
Could you point me to the url where I can see the error, I'd like to
understand what the problem is a bit more.
Thanks
Scott
2008/6/13 <ha...@apache.org>:
> Author: hansbak
> Date: Thu Jun 12 21:36:16 2008
> New Revision: 667333
>
> URL: http://svn.apache.org/viewvc?rev=667333&view=rev
> Log:
> correct variable type problem causing a muliply by null error, it seems
> that this used in many more places. I am not sure if this is the correct
> solution however this works from the request and from the screen
>
> Modified:
>
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy
>
> Modified:
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy?rev=667333&r1=667332&r2=667333&view=diff
>
> ==============================================================================
> ---
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy
> (original)
> +++
> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy
> Thu Jun 12 21:36:16 2008
> @@ -21,18 +21,14 @@
> context.itemsList = itemsList;
>
> // set the page parameters
> -viewIndex = 0;
> -try {
> - viewIndex = parameters.VIEW_INDEX as int;
> -} catch (Exception e) {
> - viewIndex = 0;
> +Integer viewIndex = 0;
> +if (parameters.VIEW_INDEX) {
> + viewIndex = new Integer(parameters.VIEW_INDEX);
> }
>
> -viewSize = 20;
> -try {
> - viewSize = parameters.VIEW_SIZE as int;
> -} catch (Exception e) {
> - viewSize = 20;
> +Integer viewSize = 20;
> +if (parameters.VIEW_SIZE) {
> + viewSize = new Integer(parameters.VIEW_SIZE);
> }
>
> listSize = 0;
>
>
>
Re: svn commit: r667333 - /ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy
Posted by Scott Gray <le...@gmail.com>.
Never mind found it :-)
Scott
2008/6/13 Scott Gray <le...@gmail.com>:
> Hi Hans
>
> Could you point me to the url where I can see the error, I'd like to
> understand what the problem is a bit more.
>
> Thanks
> Scott
>
> 2008/6/13 <ha...@apache.org>:
>
> Author: hansbak
>> Date: Thu Jun 12 21:36:16 2008
>> New Revision: 667333
>>
>> URL: http://svn.apache.org/viewvc?rev=667333&view=rev
>> Log:
>> correct variable type problem causing a muliply by null error, it seems
>> that this used in many more places. I am not sure if this is the correct
>> solution however this works from the request and from the screen
>>
>> Modified:
>>
>> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy
>>
>> Modified:
>> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy?rev=667333&r1=667332&r2=667333&view=diff
>>
>> ==============================================================================
>> ---
>> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy
>> (original)
>> +++
>> ofbiz/trunk/applications/product/webapp/catalog/WEB-INF/actions/config/FindProductConfigItems.groovy
>> Thu Jun 12 21:36:16 2008
>> @@ -21,18 +21,14 @@
>> context.itemsList = itemsList;
>>
>> // set the page parameters
>> -viewIndex = 0;
>> -try {
>> - viewIndex = parameters.VIEW_INDEX as int;
>> -} catch (Exception e) {
>> - viewIndex = 0;
>> +Integer viewIndex = 0;
>> +if (parameters.VIEW_INDEX) {
>> + viewIndex = new Integer(parameters.VIEW_INDEX);
>> }
>>
>> -viewSize = 20;
>> -try {
>> - viewSize = parameters.VIEW_SIZE as int;
>> -} catch (Exception e) {
>> - viewSize = 20;
>> +Integer viewSize = 20;
>> +if (parameters.VIEW_SIZE) {
>> + viewSize = new Integer(parameters.VIEW_SIZE);
>> }
>>
>> listSize = 0;
>>
>>
>>
>