You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Alessandro Solimando (Jira)" <ji...@apache.org> on 2021/12/19 09:18:00 UTC
[jira] [Resolved] (CALCITE-4917) Add test for 'a IS NOT NULL AND a = b' simplification
[ https://issues.apache.org/jira/browse/CALCITE-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alessandro Solimando resolved CALCITE-4917.
-------------------------------------------
Resolution: Fixed
Fixed in [{{7a7b37f}}|https://github.com/apache/calcite/commit/7a7b37fc1f4bd2121643539b0fd8e9c4f0f8ed09], thanks [~vlsi] and [~Chunwei Lei] for the review!
> Add test for 'a IS NOT NULL AND a = b' simplification
> -----------------------------------------------------
>
> Key: CALCITE-4917
> URL: https://issues.apache.org/jira/browse/CALCITE-4917
> Project: Calcite
> Issue Type: Test
> Components: core
> Affects Versions: 1.28.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Simplification (from _RexSimplify_ class) is mostly covered in {_}RexProgramTest{_}, but tests for expressions of the form "IS NOT NULL(a) AND a=b" (with nullable and not nullable types) seem to be missing.
>
> Since I had to write tests to make sure the simplification was as expected, I assume others might end up doing the same, and that the tests will both act as documentation and it will also protect against regressions.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)