You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Hanifi Gunes <ha...@gmail.com> on 2015/06/04 00:24:45 UTC
Review Request 35030: DRILL-1760: implement count(nested-type)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35030/
-----------------------------------------------------------
Review request for drill and Mehant Baid.
Repository: drill-git
Description
-------
DRILL-1760: implement count(nested-type)
Diffs
-----
exec/java-exec/src/main/codegen/data/CountAggrTypes.tdd 53e25f73ed88846cb05ad95b6aeaa722409f7bd4
exec/java-exec/src/main/codegen/templates/CountAggregateFunctions.java 71ac6a7dc831de9917e9468c2630f2242a576aeb
exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d80254abee8d380586fb4be64fee335b24
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java d5a0d6268378d958c2e8b50826e6b78bd0c1850f
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java d0f38c2a397aac7eaad247c39b4b856c89c970a0
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java a97847ba07e2543b122009a06eafccf06b89b43a
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java 36e9beedbbb037564962d868b276e5d9d0c14140
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java b2fe7b7fc532bfd0b52559864404906107132ea9
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/SingleMapReaderImpl.java 1b39775f35403ad526756cc7fe5e08d2c393a99e
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestCountFunctions.java PRE-CREATION
exec/java-exec/src/test/resources/functions/count-data.json PRE-CREATION
exec/java-exec/src/test/resources/parquet/count-data.parquet PRE-CREATION
Diff: https://reviews.apache.org/r/35030/diff/
Testing
-------
Thanks,
Hanifi Gunes
Re: Review Request 35030: DRILL-1760: implement count(nested-type)
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35030/#review86519
-----------------------------------------------------------
Minor comment.
exec/java-exec/src/main/codegen/data/CountAggrTypes.tdd
<https://reviews.apache.org/r/35030/#comment138575>
I think we should remove this out of freemarker template and have the implementation directly in a separate class. We are introducing branching in the template (which reduces readability) but we are only adding only one new function.
- Mehant Baid
On June 3, 2015, 10:27 p.m., Hanifi Gunes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35030/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 10:27 p.m.)
>
>
> Review request for drill and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> DRILL-1760: implement count(nested-type)
>
> CountAggrTypes.java && CountAggregateFunctions.java
> - Introduced count over nested type
>
> Vectors & readers
> - Implemented isSet/isNull to behave as expected since these methods are now used by count(complex-type)
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/data/CountAggrTypes.tdd 53e25f73ed88846cb05ad95b6aeaa722409f7bd4
> exec/java-exec/src/main/codegen/templates/CountAggregateFunctions.java 71ac6a7dc831de9917e9468c2630f2242a576aeb
> exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d80254abee8d380586fb4be64fee335b24
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java d5a0d6268378d958c2e8b50826e6b78bd0c1850f
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java d0f38c2a397aac7eaad247c39b4b856c89c970a0
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java a97847ba07e2543b122009a06eafccf06b89b43a
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java 36e9beedbbb037564962d868b276e5d9d0c14140
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java b2fe7b7fc532bfd0b52559864404906107132ea9
> exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/SingleMapReaderImpl.java 1b39775f35403ad526756cc7fe5e08d2c393a99e
> exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestCountFunctions.java PRE-CREATION
> exec/java-exec/src/test/resources/functions/count-data.json PRE-CREATION
> exec/java-exec/src/test/resources/parquet/count-data.parquet PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35030/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hanifi Gunes
>
>
Re: Review Request 35030: DRILL-1760: implement count(nested-type)
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35030/
-----------------------------------------------------------
(Updated June 3, 2015, 10:27 p.m.)
Review request for drill and Mehant Baid.
Changes
-------
added description
Repository: drill-git
Description (updated)
-------
DRILL-1760: implement count(nested-type)
CountAggrTypes.java && CountAggregateFunctions.java
- Introduced count over nested type
Vectors & readers
- Implemented isSet/isNull to behave as expected since these methods are now used by count(complex-type)
Diffs
-----
exec/java-exec/src/main/codegen/data/CountAggrTypes.tdd 53e25f73ed88846cb05ad95b6aeaa722409f7bd4
exec/java-exec/src/main/codegen/templates/CountAggregateFunctions.java 71ac6a7dc831de9917e9468c2630f2242a576aeb
exec/java-exec/src/main/codegen/templates/RepeatedValueVectors.java 7b2b78d80254abee8d380586fb4be64fee335b24
exec/java-exec/src/main/java/org/apache/drill/exec/vector/BaseRepeatedValueVector.java d5a0d6268378d958c2e8b50826e6b78bd0c1850f
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java d0f38c2a397aac7eaad247c39b4b856c89c970a0
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java a97847ba07e2543b122009a06eafccf06b89b43a
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java 36e9beedbbb037564962d868b276e5d9d0c14140
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java b2fe7b7fc532bfd0b52559864404906107132ea9
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/SingleMapReaderImpl.java 1b39775f35403ad526756cc7fe5e08d2c393a99e
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestCountFunctions.java PRE-CREATION
exec/java-exec/src/test/resources/functions/count-data.json PRE-CREATION
exec/java-exec/src/test/resources/parquet/count-data.parquet PRE-CREATION
Diff: https://reviews.apache.org/r/35030/diff/
Testing
-------
Thanks,
Hanifi Gunes