You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/06/26 00:53:12 UTC

[GitHub] [phoenix] gjacoby126 commented on pull request #801: PHOENIX-5951 - Index rebuild output logging for past-max-lookback row…

gjacoby126 commented on pull request #801:
URL: https://github.com/apache/phoenix/pull/801#issuecomment-649888902


   @kadirozde - please take a look at the change to the IndexRebuildRegionScanner when you have a moment. 
   
   When testing the max lookback counters and output logging, I found that ONLY (and I assume BEFORE, AFTER and BOTH) rebuilds were being treated as NONEs because the IndexRebuildRegionScanner wasn't setting verifyType. I'm thinking this got introduced in PHOENIX-5928, but I'm confused why the IndexToolIT.testSecondaryIndex:308 check for the valid counter in a BEFORE rebuild didn't catch this. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org