[jira] [Comment Edited] (ARTEMIS-1001) slow-consumer-check-period is in minutes but behaves like with seconds

["Justin Bertram (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885890#comment-15885890 ] 

Justin Bertram edited comment on ARTEMIS-1001 at 2/27/17 3:10 PM:
------------------------------------------------------------------

If you go back and look at the [original commit|https://github.com/hornetq/hornetq/commit/8bf6daf220579fa375d1a5d03b42b48f1c5dd015], you can see that the implementation has always used seconds, but parts of the documentation referenced minutes.  Changing the documentation from minutes to seconds, which ARTEMIS-504 did, was the correct thing to do.  Slow consumers can have a significant impact on a system so checking for them every 5 *minutes* by default would be too long, IMO.  Please go ahead and close this JIRA and the related PR.


was (Author: jbertram):
If you got back and look at the [original commit|https://github.com/hornetq/hornetq/commit/8bf6daf220579fa375d1a5d03b42b48f1c5dd015], you can see that the implementation has always used seconds, but parts of the documentation referenced minutes.  Changing the documentation from minutes to seconds, which ARTEMIS-504 did, was the correct thing to do.  Slow consumers can have a significant impact on a system so checking for them every 5 *minutes* by default would be too long, IMO.  Please go ahead and close this JIRA and the related PR.

> slow-consumer-check-period is in minutes but behaves like with seconds
> ----------------------------------------------------------------------
>
>                 Key: ARTEMIS-1001
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1001
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 1.5.3
>            Reporter: Miroslav Novak
>
> Attribute {{slow-consumer-check-period}} is in minutes but {{SlowConsumerReaperRunnable} thread is scheduled as it's configured with seconds.
> Problem is in {{QueueImpl.scheduleSlowConsumerReaper}} method:
> {code}
> slowConsumerReaperFuture = scheduledExecutor.scheduleWithFixedDelay(slowConsumerReaperRunnable, settings.getSlowConsumerCheckPeriod(), settings.getSlowConsumerCheckPeriod(), TimeUnit.SECONDS);
> {code}
> contains {{TimeUnit.SECONDS}} instead of {{TimeUnit.MINUTES}}. 
> I tried to debug it and can see that {{settings.getSlowConsumerCheckPeriod()}} returns 1 which is in minutes. This seems to be easy fix.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)