You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/31 02:17:23 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39318: [SPARK-41773][CONNECT][PYTHON] Enable the doctests for window functions
zhengruifeng opened a new pull request, #39318:
URL: https://github.com/apache/spark/pull/39318
### What changes were proposed in this pull request?
1, Enable the doctests for window functions
2, Add additional test in connect
### Why are the changes needed?
for test coverage
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
enabled and added tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39318: [SPARK-41773][CONNECT][PYTHON][TESTS] Enable the doctests for window functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39318: [SPARK-41773][CONNECT][PYTHON][TESTS] Enable the doctests for window functions
URL: https://github.com/apache/spark/pull/39318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39318: [SPARK-41773][CONNECT][PYTHON][TESTS] Enable the doctests for window functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39318:
URL: https://github.com/apache/spark/pull/39318#issuecomment-1368151010
@dongjoon-hyun yes, it should use `[TESTS]`, thanks for the reminder!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39318: [SPARK-41773][CONNECT][PYTHON][TESTS] Enable the doctests for window functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39318:
URL: https://github.com/apache/spark/pull/39318#issuecomment-1368165572
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39318: [SPARK-41773][CONNECT][PYTHON][TESTS] Enable the doctests for window functions
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39318:
URL: https://github.com/apache/spark/pull/39318#issuecomment-1368166022
thank you for the reviews @dongjoon-hyun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org