You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/03/04 19:39:07 UTC
[PR] small doc tidy up [incubator-pekko]
pjfanning opened a new pull request, #1177:
URL: https://github.com/apache/incubator-pekko/pull/1177
* minor formatting issue with release notes - preoperly indent one line (see https://pekko.apache.org/docs/pekko/current/release-notes/index.html#1-0-3-m1 - wiki notes line is not indented when it was meant to be)
* I think the splitWhen header in the migration guides looks untidy (see https://pekko.apache.org/docs/pekko/snapshot/project/migration-guide-1.0.x-1.1.x.html#source-splitwhen-flow-splitwhen-source-splitafter-flow-splitafter-behavioural-change)
* use 'behavior' - US spelling - current docs mix both UK and US spelling and we generally seem to use US spellings (e.g. color as opposed to colour)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] small doc tidy up [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1177:
URL: https://github.com/apache/incubator-pekko/pull/1177#discussion_r1512088634
##########
docs/src/main/paradox/project/migration-guide-1.0.x-1.1.x.md:
##########
@@ -14,11 +14,11 @@ You may have to add explicit dependencies to the new Apache Pekko version in you
That said, there are some changes to configuration and behavior that should be considered, so
reading this migration guide and testing your application thoroughly is recommended.
-## `Source.splitWhen`/`Flow.splitWhen`/`Source.splitAfter`/`Flow.splitAfter` behavioural change
+## splitWhen/splitAfter behavior change
Review Comment:
How about: Pekko Stream operator splitWhen/splitAfter behavior change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] small doc tidy up [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1177:
URL: https://github.com/apache/incubator-pekko/pull/1177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] small doc tidy up [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1177:
URL: https://github.com/apache/incubator-pekko/pull/1177#discussion_r1512088634
##########
docs/src/main/paradox/project/migration-guide-1.0.x-1.1.x.md:
##########
@@ -14,11 +14,11 @@ You may have to add explicit dependencies to the new Apache Pekko version in you
That said, there are some changes to configuration and behavior that should be considered, so
reading this migration guide and testing your application thoroughly is recommended.
-## `Source.splitWhen`/`Flow.splitWhen`/`Source.splitAfter`/`Flow.splitAfter` behavioural change
+## splitWhen/splitAfter behavior change
Review Comment:
How about: Stream splitWhen/splitAfter operator's behavior changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] small doc tidy up [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1177:
URL: https://github.com/apache/incubator-pekko/pull/1177#discussion_r1512088634
##########
docs/src/main/paradox/project/migration-guide-1.0.x-1.1.x.md:
##########
@@ -14,11 +14,11 @@ You may have to add explicit dependencies to the new Apache Pekko version in you
That said, there are some changes to configuration and behavior that should be considered, so
reading this migration guide and testing your application thoroughly is recommended.
-## `Source.splitWhen`/`Flow.splitWhen`/`Source.splitAfter`/`Flow.splitAfter` behavioural change
+## splitWhen/splitAfter behavior change
Review Comment:
How about: Pekko Stream splitWhen/splitAfter operator behavior change
##########
docs/src/main/paradox/project/migration-guide-1.0.x-1.1.x.md:
##########
@@ -14,11 +14,11 @@ You may have to add explicit dependencies to the new Apache Pekko version in you
That said, there are some changes to configuration and behavior that should be considered, so
reading this migration guide and testing your application thoroughly is recommended.
-## `Source.splitWhen`/`Flow.splitWhen`/`Source.splitAfter`/`Flow.splitAfter` behavioural change
+## splitWhen/splitAfter behavior change
Review Comment:
How about: Pekko Stream splitWhen/splitAfter operator behavior changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] small doc tidy up [incubator-pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #1177:
URL: https://github.com/apache/incubator-pekko/pull/1177#discussion_r1512445072
##########
actor-testkit-typed/src/main/scala/org/apache/pekko/actor/testkit/typed/internal/ActorSystemStub.scala:
##########
@@ -137,7 +137,7 @@ import pekko.util.FutureConverters._
@InternalApi private[pekko] object ActorSystemStub {
object config {
- // this is backward compatible with the old behaviour, hence it uses the loader used to load the test-kit
Review Comment:
Makes sense to be in line with the class names. Have we documented somewhere that we prefer American English over British English so we can move in that direction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] small doc tidy up [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1177:
URL: https://github.com/apache/incubator-pekko/pull/1177#discussion_r1518569536
##########
docs/src/main/paradox/project/migration-guide-1.0.x-1.1.x.md:
##########
@@ -14,11 +14,11 @@ You may have to add explicit dependencies to the new Apache Pekko version in you
That said, there are some changes to configuration and behavior that should be considered, so
reading this migration guide and testing your application thoroughly is recommended.
-## `Source.splitWhen`/`Flow.splitWhen`/`Source.splitAfter`/`Flow.splitAfter` behavioural change
+## splitWhen/splitAfter behavior change
Review Comment:
to be honest - headers are supposed to short as possible - if a reader want the full detail, they can read the paragraph
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org