You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by cs...@apache.org on 2026/04/19 16:29:27 UTC
(maven-resolver) branch master updated: Lower various component selection debug noise (#1841)
This is an automated email from the ASF dual-hosted git repository.
cstamas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-resolver.git
The following commit(s) were added to refs/heads/master by this push:
new 64fc4af12 Lower various component selection debug noise (#1841)
64fc4af12 is described below
commit 64fc4af12bae08138eb818849697ac480240a3c1
Author: Tamas Cservenak <ta...@cservenak.net>
AuthorDate: Sun Apr 19 18:29:21 2026 +0200
Lower various component selection debug noise (#1841)
They all emit stack traces, and just make noise.
Make clear at DEBUG what is happening, while retain
ability for stack traces at TRACE level.
---
.../internal/impl/DefaultLocalRepositoryProvider.java | 16 +++++++++++++++-
.../impl/DefaultRepositoryConnectorProvider.java | 16 +++++++++++++++-
.../internal/impl/DefaultRepositoryLayoutProvider.java | 16 +++++++++++++++-
.../aether/internal/impl/DefaultTransporterProvider.java | 16 +++++++++++++++-
4 files changed, 60 insertions(+), 4 deletions(-)
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultLocalRepositoryProvider.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultLocalRepositoryProvider.java
index ab448d461..b749f7a68 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultLocalRepositoryProvider.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultLocalRepositoryProvider.java
@@ -65,6 +65,8 @@ public class DefaultLocalRepositoryProvider implements LocalRepositoryProvider {
localRepositoryManagerFactories,
LocalRepositoryManagerFactory::getPriority);
+ LOGGER.debug("Selecting LocalRepositoryManager for {}", repository);
+
List<NoLocalRepositoryManagerException> errors = new ArrayList<>();
for (PrioritizedComponent<LocalRepositoryManagerFactory> factory : factories.getEnabled()) {
try {
@@ -83,7 +85,19 @@ public class DefaultLocalRepositoryProvider implements LocalRepositoryProvider {
return manager;
} catch (NoLocalRepositoryManagerException e) {
// continue and try next factory
- LOGGER.debug("Could not obtain local repository manager for {}", repository, e);
+ if (LOGGER.isTraceEnabled()) {
+ LOGGER.trace(
+ "LRM factory {} did not provide LRM for {}",
+ factory.getComponent().getClass(),
+ repository,
+ e);
+ } else {
+ LOGGER.debug(
+ "LRM factory {} did not provide LRM for {}: {}",
+ factory.getComponent().getClass(),
+ repository,
+ e.getMessage());
+ }
errors.add(e);
}
}
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java
index c655bc50e..8c969491a 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryConnectorProvider.java
@@ -76,6 +76,8 @@ public class DefaultRepositoryConnectorProvider implements RepositoryConnectorPr
PrioritizedComponents<RepositoryConnectorFactory> factories = PrioritizedComponents.reuseOrCreate(
session, RepositoryConnectorFactory.class, connectorFactories, RepositoryConnectorFactory::getPriority);
+ LOGGER.debug("Selecting RepositoryConnector for {}", repository);
+
List<NoRepositoryConnectorException> errors = new ArrayList<>();
for (PrioritizedComponent<RepositoryConnectorFactory> factory : factories.getEnabled()) {
try {
@@ -100,7 +102,19 @@ public class DefaultRepositoryConnectorProvider implements RepositoryConnectorPr
return connector;
} catch (NoRepositoryConnectorException e) {
// continue and try next factory
- LOGGER.debug("Could not obtain connector factory for {}", repository, e);
+ if (LOGGER.isTraceEnabled()) {
+ LOGGER.trace(
+ "Connector factory {} did not provide connector for {}",
+ factory.getComponent().getClass(),
+ repository,
+ e);
+ } else {
+ LOGGER.debug(
+ "Connector factory {} did not provide connector for {}: {}",
+ factory.getComponent().getClass(),
+ repository,
+ e.getMessage());
+ }
errors.add(e);
}
}
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryLayoutProvider.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryLayoutProvider.java
index b457dc3b6..8fea1e531 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryLayoutProvider.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultRepositoryLayoutProvider.java
@@ -62,13 +62,27 @@ public final class DefaultRepositoryLayoutProvider implements RepositoryLayoutPr
PrioritizedComponents<RepositoryLayoutFactory> factories = PrioritizedComponents.reuseOrCreate(
session, RepositoryLayoutFactory.class, layoutFactories, RepositoryLayoutFactory::getPriority);
+ LOGGER.debug("Selecting RepositoryLayout for {}", repository);
+
List<NoRepositoryLayoutException> errors = new ArrayList<>();
for (PrioritizedComponent<RepositoryLayoutFactory> factory : factories.getEnabled()) {
try {
return factory.getComponent().newInstance(session, repository);
} catch (NoRepositoryLayoutException e) {
// continue and try next factory
- LOGGER.debug("Could not obtain layout factory for {}", repository, e);
+ if (LOGGER.isTraceEnabled()) {
+ LOGGER.trace(
+ "Layout factory {} did not provide layout for {}",
+ factory.getComponent().getClass(),
+ repository,
+ e);
+ } else {
+ LOGGER.debug(
+ "Layout factory {} did not provide layout for {}: {}",
+ factory.getComponent().getClass(),
+ repository,
+ e.getMessage());
+ }
errors.add(e);
}
}
diff --git a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTransporterProvider.java b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTransporterProvider.java
index 615cfad7e..64be6b801 100644
--- a/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTransporterProvider.java
+++ b/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTransporterProvider.java
@@ -64,6 +64,8 @@ public final class DefaultTransporterProvider implements TransporterProvider {
PrioritizedComponents<TransporterFactory> factories = PrioritizedComponents.reuseOrCreate(
session, TransporterFactory.class, transporterFactories, TransporterFactory::getPriority);
+ LOGGER.debug("Selecting Transporter for {}", repository);
+
List<NoTransporterException> errors = new ArrayList<>();
for (PrioritizedComponent<TransporterFactory> factory : factories.getEnabled()) {
try {
@@ -101,7 +103,19 @@ public final class DefaultTransporterProvider implements TransporterProvider {
return transporter;
} catch (NoTransporterException e) {
// continue and try next factory
- LOGGER.debug("Could not obtain transporter factory for {}", repository, e);
+ if (LOGGER.isTraceEnabled()) {
+ LOGGER.trace(
+ "Transporter factory {} did not provide Transporter for {}",
+ factory.getComponent().getClass(),
+ repository,
+ e);
+ } else {
+ LOGGER.debug(
+ "Transporter factory {} did not provide Transporter for {}: {}",
+ factory.getComponent().getClass(),
+ repository,
+ e.getMessage());
+ }
errors.add(e);
}
}