You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Ismael Juma <mi...@juma.me.uk> on 2015/06/02 21:06:45 UTC

Re: Review Request 34502: Patch for KAFKA-2187

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34502/
-----------------------------------------------------------

(Updated June 2, 2015, 7:06 p.m.)


Review request for kafka.


Bugs: KAFKA-2187
    https://issues.apache.org/jira/browse/KAFKA-2187


Repository: kafka


Description
-------

KAFKA-2187; Introduce merge-kafka-pr.py script


Diffs (updated)
-----

  kafka-merge-pr.py PRE-CREATION 

Diff: https://reviews.apache.org/r/34502/diff/


Testing
-------

Tested by:

* Setting environment variables `PR_REMOTE_NAME` and `PUSH_REMOTE_NAME` to `origin` (defaults are `apache-github` and `apache` respectively)
* Setting environment variable `GITHUB_USER` to `ijuma` (default is `apache`).
* Setting environment variables `JIRA_USERNAME` and `JIRA_PASSWORD` to my credentials.
* Running `python kafka-merge-pr-py`, choosing to merge PR 3 (https://github.com/ijuma/kafka/pull/3) and answered the prompts, including the one that asked whether I wanted to close the relevant JIRA (https://issues.apache.org/jira/browse/KAFKA-2187)


Thanks,

Ismael Juma