You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2020/01/11 01:25:10 UTC
[kudu-CR] fs: remove test-only constructor
Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15010
to review the following change.
Change subject: fs: remove test-only constructor
......................................................................
fs: remove test-only constructor
Change-Id: I11024a2f28123bba3e3989ddd5e68f581481d5fb
---
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_meta_manager-stress-test.cc
M src/kudu/consensus/consensus_meta_manager-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log_cache-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/tablet/delta_compaction-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/tablet-harness.h
M src/kudu/tools/kudu-tool-test.cc
16 files changed, 37 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/15010/1
--
To view, visit http://gerrit.cloudera.org:8080/15010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I11024a2f28123bba3e3989ddd5e68f581481d5fb
Gerrit-Change-Number: 15010
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] fs: remove test-only constructor
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15010 )
Change subject: fs: remove test-only constructor
......................................................................
Patch Set 2:
> 17:27:41 /home/jenkins-slave/workspace/kudu-master/0/src/kudu/tablet/compaction-test.cc:445:17: error: no matching constructor for initialization of 'kudu::FsManager'
> 17:27:41 FsManager fs_manager(env_, FLAGS_merge_benchmark_input_dir);
Yeah. What's odd is that this code was compiled out of DEBUG builds, but not ASAN/TSAN. DoBenchmark is only called in RELEASE builds.
--
To view, visit http://gerrit.cloudera.org:8080/15010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11024a2f28123bba3e3989ddd5e68f581481d5fb
Gerrit-Change-Number: 15010
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 11 Jan 2020 23:26:01 +0000
Gerrit-HasComments: No
[kudu-CR] fs: remove test-only constructor
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15010
to look at the new patch set (#2).
Change subject: fs: remove test-only constructor
......................................................................
fs: remove test-only constructor
Change-Id: I11024a2f28123bba3e3989ddd5e68f581481d5fb
---
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_meta_manager-stress-test.cc
M src/kudu/consensus/consensus_meta_manager-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log_cache-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/delta_compaction-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/tablet-harness.h
M src/kudu/tools/kudu-tool-test.cc
17 files changed, 38 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/15010/2
--
To view, visit http://gerrit.cloudera.org:8080/15010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I11024a2f28123bba3e3989ddd5e68f581481d5fb
Gerrit-Change-Number: 15010
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] fs: remove test-only constructor
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15010 )
Change subject: fs: remove test-only constructor
......................................................................
Patch Set 1:
It seems there is one place which required the constructor just removed:
17:27:41 /home/jenkins-slave/workspace/kudu-master/0/src/kudu/tablet/compaction-test.cc:445:17: error: no matching constructor for initialization of 'kudu::FsManager'
17:27:41 FsManager fs_manager(env_, FLAGS_merge_benchmark_input_dir);
--
To view, visit http://gerrit.cloudera.org:8080/15010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11024a2f28123bba3e3989ddd5e68f581481d5fb
Gerrit-Change-Number: 15010
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 11 Jan 2020 04:30:48 +0000
Gerrit-HasComments: No
[kudu-CR] fs: remove test-only constructor
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15010 )
Change subject: fs: remove test-only constructor
......................................................................
fs: remove test-only constructor
Change-Id: I11024a2f28123bba3e3989ddd5e68f581481d5fb
Reviewed-on: http://gerrit.cloudera.org:8080/15010
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/cfile-test-base.h
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_meta_manager-stress-test.cc
M src/kudu/consensus/consensus_meta_manager-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log_cache-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/delta_compaction-test.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/tablet-harness.h
M src/kudu/tools/kudu-tool-test.cc
17 files changed, 38 insertions(+), 41 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I11024a2f28123bba3e3989ddd5e68f581481d5fb
Gerrit-Change-Number: 15010
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] fs: remove test-only constructor
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15010 )
Change subject: fs: remove test-only constructor
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15010
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11024a2f28123bba3e3989ddd5e68f581481d5fb
Gerrit-Change-Number: 15010
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Jan 2020 02:01:58 +0000
Gerrit-HasComments: No