[GitHub] sandeep-krishnamurthy commented on a change in pull request #9169: Make versions of python dependencies like numpy, deterministic.

[GitBox <gi...@apache.org>]

sandeep-krishnamurthy commented on a change in pull request #9169: Make versions of python dependencies like numpy, deterministic.
URL: https://github.com/apache/incubator-mxnet/pull/9169#discussion_r158397924
 
 

 ##########
 File path: python/setup.py
 ##########
 @@ -28,7 +28,7 @@
 else:
     from setuptools import setup
     from setuptools.extension import Extension
-    kwargs = {'install_requires': ['numpy', 'requests', 'graphviz'], 'zip_safe': False}
+    kwargs = {'install_requires': ['numpy<=1.13.3', 'requests==2.18.4', 'graphviz==0.8.1'], 'zip_safe': False}
 
 Review comment:
   Jonathan - I was thinking of large majority of users who has 1.8.2 (lower than 1.13.3) version of Numpy. Which we have tested works well with MXNet. So I thought of capping to the major version that is latest and tested rather than forcing users to upgrade.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services