You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Thorsten Scherler <th...@juntadeandalucia.es> on 2007/08/22 15:15:04 UTC

faq-to-document.xsl

Hi all,

the http://issues.apache.org/bugzilla/show_bug.cgi?id=42350 is caused by
the faq-to-document.xsl:
...
<body>
        <section>
          <title>Questions</title>
          <xsl:apply-templates select="faq|part"/>
        </section>
      </body>
...

This causes only one level 1 section:
<tocitems>
<tocitem level="1" href="#Questions" title="Questions">
<tocitem level="2" href="#getting_started" title="1. Getting Started and Building Lenya">
...

But if one configures the skinconf toc @min-sections to 2 then it results in the above bug.

I would like to patch it the following way:
-        <section>
-          <title>Questions</title>
-          <xsl:apply-templates select="faq|part"/>
-        </section>
+        <xsl:apply-templates select="faq|part"/>

Did I miss something or can I go ahead and change the code?

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


RE: faq-to-document.xsl

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Thu, 2007-08-23 at 07:50 +0800, Gav.... wrote:
> Hi Thorsten,
> 
> Needs more investigation I think.

Actually I do not think so. I am sure that the problem is which I
pointed out before.

> 
> Our FAQ [1] has a ToC and works just fine.

Forrest:
https://svn.apache.org/repos/asf/forrest/trunk/site-author/skinconf.xml
<toc max-depth="2" min-sections="1" location="page"/>

Lenya:
https://svn.apache.org/repos/asf/lenya/docu/src/documentation/skinconf.xml
<toc max-depth="3" min-sections="2" location="page"/>

In the pelt skin we have in site-to-xhtml:
<xsl:template match="div[@id='skinconf-toc-page']">
...
 <xsl:if test="(count(//tocitems/tocitem) >= $config/toc/@min-sections)
or (//tocitems/@force = 'true')">

Since Forrest has count(//tocitems/tocitem)=1 which is >=
$config/toc/@min-sections) =1 we see the toc. In lenya it is 1 >=2 which
is false.

salu2
> 
> Gav...
> 
> [1] - http://forrest.apache.org/docs_0_90/faq.html
> 
> 
> 
> > -----Original Message-----
> > From: Thorsten Scherler [mailto:thorsten.scherler.ext@juntadeandalucia.es]
> > Sent: Wednesday, 22 August 2007 9:15 PM
> > To: dev@forrest.apache.org
> > Subject: faq-to-document.xsl
> > 
> > Hi all,
> > 
> > the http://issues.apache.org/bugzilla/show_bug.cgi?id=42350 is caused by
> > the faq-to-document.xsl:
> > ...
> > <body>
> >         <section>
> >           <title>Questions</title>
> >           <xsl:apply-templates select="faq|part"/>
> >         </section>
> >       </body>
> > ...
> > 
> > This causes only one level 1 section:
> > <tocitems>
> > <tocitem level="1" href="#Questions" title="Questions">
> > <tocitem level="2" href="#getting_started" title="1. Getting Started and
> > Building Lenya">
> > ...
> > 
> > But if one configures the skinconf toc @min-sections to 2 then it results
> > in the above bug.
> > 
> > I would like to patch it the following way:
> > -        <section>
> > -          <title>Questions</title>
> > -          <xsl:apply-templates select="faq|part"/>
> > -        </section>
> > +        <xsl:apply-templates select="faq|part"/>
> > 
> > Did I miss something or can I go ahead and change the code?
> > 
> > salu2
> > --
> > Thorsten Scherler                                 thorsten.at.apache.org
> > Open Source Java                      consulting, training and solutions
> > 
> > 
> > --
> > Internal Virus Database is out-of-date.
> > Checked by AVG Free Edition.
> > Version: 7.5.476 / Virus Database: 269.11.2/933 - Release Date: 8/2/2007
> > 2:22 PM
> 
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


RE: faq-to-document.xsl

Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Thu, 2007-08-23 at 07:53 +0800, Gav.... wrote:
> In addition, your 1.2 docs faq shows a ToC, just your 2.0 does not.
> 
> http://lenya.apache.org/docs/1_2_x/how-to/faq.html


https://svn.apache.org/repos/asf/lenya/docu/src/documentation/content/xdocs/docs/1_2_x/how-to/faq.xml

<!DOCTYPE document PUBLIC "-//APACHE//DTD Documentation V2.0//EN"
"http://forrest.apache.org/dtd/document-v20.dtd">

This document is called faq but is an xdocs. 

...but this perfectly demonstrate the problem. 

Why would I want to have a surrounding section called Questions like we
have in the forrest one? It should be like above link.

salu2

> 
> 
> Gav...
> 
> > -----Original Message-----
> > From: Gav.... [mailto:brightoncomputers@brightontown.com.au]
> > Sent: Thursday, 23 August 2007 7:50 AM
> > To: dev@forrest.apache.org
> > Subject: RE: faq-to-document.xsl
> > 
> > Hi Thorsten,
> > 
> > Needs more investigation I think.
> > 
> > Our FAQ [1] has a ToC and works just fine.
> > 
> > Gav...
> > 
> > [1] - http://forrest.apache.org/docs_0_90/faq.html
> > 
> > 
> > 
> > > -----Original Message-----
> > > From: Thorsten Scherler
> > [mailto:thorsten.scherler.ext@juntadeandalucia.es]
> > > Sent: Wednesday, 22 August 2007 9:15 PM
> > > To: dev@forrest.apache.org
> > > Subject: faq-to-document.xsl
> > >
> > > Hi all,
> > >
> > > the http://issues.apache.org/bugzilla/show_bug.cgi?id=42350 is caused by
> > > the faq-to-document.xsl:
> > > ...
> > > <body>
> > >         <section>
> > >           <title>Questions</title>
> > >           <xsl:apply-templates select="faq|part"/>
> > >         </section>
> > >       </body>
> > > ...
> > >
> > > This causes only one level 1 section:
> > > <tocitems>
> > > <tocitem level="1" href="#Questions" title="Questions">
> > > <tocitem level="2" href="#getting_started" title="1. Getting Started and
> > > Building Lenya">
> > > ...
> > >
> > > But if one configures the skinconf toc @min-sections to 2 then it
> > results
> > > in the above bug.
> > >
> > > I would like to patch it the following way:
> > > -        <section>
> > > -          <title>Questions</title>
> > > -          <xsl:apply-templates select="faq|part"/>
> > > -        </section>
> > > +        <xsl:apply-templates select="faq|part"/>
> > >
> > > Did I miss something or can I go ahead and change the code?
> > >
> > > salu2
> > > --
> > > Thorsten Scherler                                 thorsten.at.apache.org
> > > Open Source Java                      consulting, training and solutions
> > >
> > >
> > > --
> > > Internal Virus Database is out-of-date.
> > > Checked by AVG Free Edition.
> > > Version: 7.5.476 / Virus Database: 269.11.2/933 - Release Date: 8/2/2007
> > > 2:22 PM
> > 
> > 
> > --
> > Internal Virus Database is out-of-date.
> > Checked by AVG Free Edition.
> > Version: 7.5.476 / Virus Database: 269.11.2/933 - Release Date: 8/2/2007
> > 2:22 PM
> 
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


RE: faq-to-document.xsl

Posted by "Gav...." <br...@brightontown.com.au>.
In addition, your 1.2 docs faq shows a ToC, just your 2.0 does not.

http://lenya.apache.org/docs/1_2_x/how-to/faq.html


Gav...

> -----Original Message-----
> From: Gav.... [mailto:brightoncomputers@brightontown.com.au]
> Sent: Thursday, 23 August 2007 7:50 AM
> To: dev@forrest.apache.org
> Subject: RE: faq-to-document.xsl
> 
> Hi Thorsten,
> 
> Needs more investigation I think.
> 
> Our FAQ [1] has a ToC and works just fine.
> 
> Gav...
> 
> [1] - http://forrest.apache.org/docs_0_90/faq.html
> 
> 
> 
> > -----Original Message-----
> > From: Thorsten Scherler
> [mailto:thorsten.scherler.ext@juntadeandalucia.es]
> > Sent: Wednesday, 22 August 2007 9:15 PM
> > To: dev@forrest.apache.org
> > Subject: faq-to-document.xsl
> >
> > Hi all,
> >
> > the http://issues.apache.org/bugzilla/show_bug.cgi?id=42350 is caused by
> > the faq-to-document.xsl:
> > ...
> > <body>
> >         <section>
> >           <title>Questions</title>
> >           <xsl:apply-templates select="faq|part"/>
> >         </section>
> >       </body>
> > ...
> >
> > This causes only one level 1 section:
> > <tocitems>
> > <tocitem level="1" href="#Questions" title="Questions">
> > <tocitem level="2" href="#getting_started" title="1. Getting Started and
> > Building Lenya">
> > ...
> >
> > But if one configures the skinconf toc @min-sections to 2 then it
> results
> > in the above bug.
> >
> > I would like to patch it the following way:
> > -        <section>
> > -          <title>Questions</title>
> > -          <xsl:apply-templates select="faq|part"/>
> > -        </section>
> > +        <xsl:apply-templates select="faq|part"/>
> >
> > Did I miss something or can I go ahead and change the code?
> >
> > salu2
> > --
> > Thorsten Scherler                                 thorsten.at.apache.org
> > Open Source Java                      consulting, training and solutions
> >
> >
> > --
> > Internal Virus Database is out-of-date.
> > Checked by AVG Free Edition.
> > Version: 7.5.476 / Virus Database: 269.11.2/933 - Release Date: 8/2/2007
> > 2:22 PM
> 
> 
> --
> Internal Virus Database is out-of-date.
> Checked by AVG Free Edition.
> Version: 7.5.476 / Virus Database: 269.11.2/933 - Release Date: 8/2/2007
> 2:22 PM


RE: faq-to-document.xsl

Posted by "Gav...." <br...@brightontown.com.au>.
Hi Thorsten,

Needs more investigation I think.

Our FAQ [1] has a ToC and works just fine.

Gav...

[1] - http://forrest.apache.org/docs_0_90/faq.html



> -----Original Message-----
> From: Thorsten Scherler [mailto:thorsten.scherler.ext@juntadeandalucia.es]
> Sent: Wednesday, 22 August 2007 9:15 PM
> To: dev@forrest.apache.org
> Subject: faq-to-document.xsl
> 
> Hi all,
> 
> the http://issues.apache.org/bugzilla/show_bug.cgi?id=42350 is caused by
> the faq-to-document.xsl:
> ...
> <body>
>         <section>
>           <title>Questions</title>
>           <xsl:apply-templates select="faq|part"/>
>         </section>
>       </body>
> ...
> 
> This causes only one level 1 section:
> <tocitems>
> <tocitem level="1" href="#Questions" title="Questions">
> <tocitem level="2" href="#getting_started" title="1. Getting Started and
> Building Lenya">
> ...
> 
> But if one configures the skinconf toc @min-sections to 2 then it results
> in the above bug.
> 
> I would like to patch it the following way:
> -        <section>
> -          <title>Questions</title>
> -          <xsl:apply-templates select="faq|part"/>
> -        </section>
> +        <xsl:apply-templates select="faq|part"/>
> 
> Did I miss something or can I go ahead and change the code?
> 
> salu2
> --
> Thorsten Scherler                                 thorsten.at.apache.org
> Open Source Java                      consulting, training and solutions
> 
> 
> --
> Internal Virus Database is out-of-date.
> Checked by AVG Free Edition.
> Version: 7.5.476 / Virus Database: 269.11.2/933 - Release Date: 8/2/2007
> 2:22 PM