[GitHub] markusthoemmes commented on issue #3330: Update Log Store Fetch

[GitBox <gi...@apache.org>]

markusthoemmes commented on issue #3330: Update Log Store Fetch
URL: https://github.com/apache/incubator-openwhisk/pull/3330#issuecomment-367934358
 
 
   I'd rather we pass in the entire `HttpRequest`. Query-string or body might be interesting to implementors as well?
   
   @rabbah this is a lot about staging changes here and I think as an MVP it makes most sense to give `fetchLogs` access to the entire `HttpRequest`.
   
   For anybody: The background of this is, that any backend Logstore might be subject to a different authentication than OpenWhisk itself. Rather than entangle everything and anything in OpenWhisk authentication means it might be beneficial to provide a "custom" API.
   
   Thinking about it, just the headers might be fine as a first step.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services