You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/04/18 10:34:29 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

zjffdu opened a new pull request #4096:
URL: https://github.com/apache/zeppelin/pull/4096


   ### What is this PR for?
   
   This is a hotfix to fix the ci failure due to dns reverse lookup issue. Some of the code is copied from pulsar project.
   https://github.com/lhotari/pulsar/commit/b4300db307f542d2ece7ad9f487f078d00210a27
   
   
   ### What type of PR is it?
   [ Hot Fix ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * 
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? NO
   * Is there breaking changes for older versions? No
   * Does this needs documentation? NO
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

Posted by GitBox <gi...@apache.org>.
cuspymd commented on a change in pull request #4096:
URL: https://github.com/apache/zeppelin/pull/4096#discussion_r615405020



##########
File path: spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkShinyInterpreterTest.java
##########
@@ -102,7 +102,7 @@ public void testSparkShinyApp() throws IOException, InterpreterException, Interr
     Thread.sleep(5 * 1000);
     // extract shiny url
     List<InterpreterResultMessage> resultMessages = context2.out.toInterpreterResultMessage();
-    assertEquals(1, resultMessages.size());
+    assertEquals(resultMessages + "", 1, resultMessages.size());

Review comment:
       The result seems be the same as `resultMessages.toString()`, but wouldn't it be better to use a consistent expression with other code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4096:
URL: https://github.com/apache/zeppelin/pull/4096#issuecomment-822128444


   Will merge it soon so that it won't block other PRs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4096:
URL: https://github.com/apache/zeppelin/pull/4096#discussion_r615421141



##########
File path: spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkShinyInterpreterTest.java
##########
@@ -102,7 +102,7 @@ public void testSparkShinyApp() throws IOException, InterpreterException, Interr
     Thread.sleep(5 * 1000);
     // extract shiny url
     List<InterpreterResultMessage> resultMessages = context2.out.toInterpreterResultMessage();
-    assertEquals(1, resultMessages.size());
+    assertEquals(resultMessages + "", 1, resultMessages.size());

Review comment:
       > The result seems be the same as `resultMessages.toString()`, but wouldn't it be better to use a consistent expression with other code?
   
   Right, let me update it 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4096:
URL: https://github.com/apache/zeppelin/pull/4096#discussion_r615417651



##########
File path: spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkShinyInterpreterTest.java
##########
@@ -102,7 +102,7 @@ public void testSparkShinyApp() throws IOException, InterpreterException, Interr
     Thread.sleep(5 * 1000);
     // extract shiny url
     List<InterpreterResultMessage> resultMessages = context2.out.toInterpreterResultMessage();
-    assertEquals(1, resultMessages.size());
+    assertEquals(resultMessages + "", 1, resultMessages.size());

Review comment:
       This change is only for diagnose to display the content of resultMessages when this assertion fails. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4096:
URL: https://github.com/apache/zeppelin/pull/4096


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org