You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by pu...@apache.org on 2019/11/06 11:56:36 UTC

[royale-asjs] branch develop updated: Added direction Style in ButtonBase

This is an automated email from the ASF dual-hosted git repository.

pushminakazi pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new e4cf69c  Added direction Style in ButtonBase
e4cf69c is described below

commit e4cf69ca5d65f4f74e47507f7ad406866a90911c
Author: pashminakazi <42...@users.noreply.github.com>
AuthorDate: Wed Nov 6 16:56:31 2019 +0500

    Added direction Style in ButtonBase
---
 .../src/main/royale/spark/components/supportClasses/ButtonBase.as        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ButtonBase.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ButtonBase.as
index 4596850..3c51a38 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ButtonBase.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ButtonBase.as
@@ -183,6 +183,7 @@ import mx.managers.IFocusManagerComponent;
  */
 //[Style(name="touchDelay", type="Number", format="Time", inherit="yes", minValue="0.0")]
 
+[Style(name="direction", type="String", inherit="yes")]
 //--------------------------------------
 //  Events
 //--------------------------------------


Re: [royale-asjs] branch develop updated: Added direction Style in ButtonBase

Posted by Alex Harui <ah...@adobe.com.INVALID>.
This doesn't look right.  In the emulation components we are implementing styles as get/set pairs.  See UIComponent.fontWeight and other converted styles and follow that pattern.

-Alex

On 11/6/19, 3:56 AM, "pushminakazi@apache.org" <pu...@apache.org> wrote:

    This is an automated email from the ASF dual-hosted git repository.
    
    pushminakazi pushed a commit to branch develop
    in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7C1356916237ed44a3b94f08d762b060da%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637086382001540891&amp;sdata=2e5k2M7%2BlltQkt1eqOA6SPK8X5z5tgqiO4L19Mf7FUs%3D&amp;reserved=0
    
    
    The following commit(s) were added to refs/heads/develop by this push:
         new e4cf69c  Added direction Style in ButtonBase
    e4cf69c is described below
    
    commit e4cf69ca5d65f4f74e47507f7ad406866a90911c
    Author: pashminakazi <42...@users.noreply.github.com>
    AuthorDate: Wed Nov 6 16:56:31 2019 +0500
    
        Added direction Style in ButtonBase
    ---
     .../src/main/royale/spark/components/supportClasses/ButtonBase.as        | 1 +
     1 file changed, 1 insertion(+)
    
    diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ButtonBase.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ButtonBase.as
    index 4596850..3c51a38 100644
    --- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ButtonBase.as
    +++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ButtonBase.as
    @@ -183,6 +183,7 @@ import mx.managers.IFocusManagerComponent;
      */
     //[Style(name="touchDelay", type="Number", format="Time", inherit="yes", minValue="0.0")]
     
    +[Style(name="direction", type="String", inherit="yes")]
     //--------------------------------------
     //  Events
     //--------------------------------------