You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (Created) (JIRA)" <ji...@apache.org> on 2011/10/17 00:34:11 UTC

[jira] [Created] (THRIFT-1391) Delphi XE Library test case: Exceptions

Delphi XE Library test case: Exceptions
---------------------------------------

                 Key: THRIFT-1391
                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
             Project: Thrift
          Issue Type: Sub-task
            Reporter: Jens Geyer
         Attachments: THRIFT-1391_Delphi_XE_exceptions_test_case.zip

Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Improved Delphi XE test cases

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment:     (was: THRIFT-1391_exception_content_test_case_rev1.patch)
    
> Improved Delphi XE test cases
> -----------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>
> Improved TestClient:
> - collects test results and reports errors
> - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
> - exception content test also included (= initial reason for this patch)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment: THRIFT-1391_exception_content_test_case_rev1.patch

Patch created against r1188945
                
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_exception_content_test_case_rev1.patch
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Patch Info: Patch Available
    
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1391_exception_content_test_case.zip
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1391) Improved Delphi XE test cases

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151716#comment-13151716 ] 

Hudson commented on THRIFT-1391:
--------------------------------

Integrated in Thrift #338 (See [https://builds.apache.org/job/Thrift/338/])
    Thrift-1391: Improved Delphi XE test cases
Client: delphi
Patch: Jens Geyer

Improved TestClient:
 - collects test results and reports errors
 - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
 - exception content test also included

                
> Improved Delphi XE test cases
> -----------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.8
>
>         Attachments: THRIFT-1391_Improved_Delphi_XE_test_cases_rev4.patch
>
>
> Improved TestClient:
> - collects test results and reports errors
> - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
> - exception content test also included (= initial reason for this patch)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134703#comment-13134703 ] 

Jake Farrell commented on THRIFT-1391:
--------------------------------------

I think you can use the existing service "void testException(1: string arg) throws(1: Xception err1)" and shouldn't need to add additional constants. Take a look at how java tests this in lib/java/test/org/apache/thrift/server/ServerTestBase.java
                
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1391_exception_content_test_case.zip
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1391) Improved Delphi XE test cases

Posted by "Jens Geyer (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150779#comment-13150779 ] 

Jens Geyer commented on THRIFT-1391:
------------------------------------

All test results are now logged and counted. At the end, the client produces a summary, which should look similar to this:
{noformat}

============================================================
163 tests performed
163 tests succeeded (100%)
0 tests failed (0%)
============================================================
{noformat}

If one or more tests fail, the tests will be listed below this summary to make it easy to find the failing test(s) in the code.

                
> Improved Delphi XE test cases
> -----------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_Improved_Delphi_XE_test_cases_rev3.patch
>
>
> Improved TestClient:
> - collects test results and reports errors
> - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
> - exception content test also included (= initial reason for this patch)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment: THRIFT-1391_exception_content_test_case.zip

Test case added to existing Test server/client
Modified:
- Thrift.Tests.thrift
- TestClient.pas
- TestServer.pas
                
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1391_Delphi_XE_exceptions_test_case.zip, THRIFT-1391_exception_content_test_case.zip
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Improved Delphi XE test cases

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment: THRIFT-1391_Improved_Delphi_XE_test_cases_rev4.patch
    
> Improved Delphi XE test cases
> -----------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_Improved_Delphi_XE_test_cases_rev3.patch, THRIFT-1391_Improved_Delphi_XE_test_cases_rev4.patch
>
>
> Improved TestClient:
> - collects test results and reports errors
> - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
> - exception content test also included (= initial reason for this patch)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Improved Delphi XE test cases

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment:     (was: THRIFT-1391_Improved_Delphi_XE_test_cases_rev3.patch)
    
> Improved Delphi XE test cases
> -----------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_Improved_Delphi_XE_test_cases_rev4.patch
>
>
> Improved TestClient:
> - collects test results and reports errors
> - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
> - exception content test also included (= initial reason for this patch)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jake Farrell (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell updated THRIFT-1391:
---------------------------------

    Component/s: Delphi - Library
       Assignee: Jens Geyer
    
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_exception_content_test_case.zip
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jens Geyer (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130135#comment-13130135 ] 

Jens Geyer commented on THRIFT-1391:
------------------------------------

I added one call (and two constants) to Thrift.Tests.thrift. I'm not quite sure if this was a good idea, since an additional function in the interface may break code.
                
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1391_exception_content_test_case.zip
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135656#comment-13135656 ] 

Jake Farrell commented on THRIFT-1391:
--------------------------------------

Jens, do you want to implement any of the TODO items listed in the patch prior to this going?
                
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_exception_content_test_case_rev1.patch
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jake Farrell (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129767#comment-13129767 ] 

Jake Farrell commented on THRIFT-1391:
--------------------------------------

Jens can you please make this part of the main test server and client so there are not a bunch of servers for each test
                
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1391_Delphi_XE_exceptions_test_case.zip
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Improved Delphi XE test cases

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

          Description: 
Improved TestClient:
- collects test results and reports errors
- added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
- exception content test also included (= initial reason for this patch)

  was:Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

    Affects Version/s: 0.8
              Summary: Improved Delphi XE test cases  (was: Delphi XE Library test case: Exceptions)
    
> Improved Delphi XE test cases
> -----------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>
> Improved TestClient:
> - collects test results and reports errors
> - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
> - exception content test also included (= initial reason for this patch)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment:     (was: THRIFT-1391_Delphi_XE_exceptions_test_case.zip)
    
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1391_exception_content_test_case.zip
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Improved Delphi XE test cases

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment:     (was: THRIFT-1391_Improved_Delphi_XE_test_cases_rev2.patch)
    
> Improved Delphi XE test cases
> -----------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_Improved_Delphi_XE_test_cases_rev3.patch
>
>
> Improved TestClient:
> - collects test results and reports errors
> - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
> - exception content test also included (= initial reason for this patch)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (THRIFT-1391) Improved Delphi XE test cases

Posted by "Jake Farrell (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell closed THRIFT-1391.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.8

Committed
                
> Improved Delphi XE test cases
> -----------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.8
>
>         Attachments: THRIFT-1391_Improved_Delphi_XE_test_cases_rev4.patch
>
>
> Improved TestClient:
> - collects test results and reports errors
> - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
> - exception content test also included (= initial reason for this patch)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jens Geyer (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130135#comment-13130135 ] 

Jens Geyer edited comment on THRIFT-1391 at 10/18/11 11:46 PM:
---------------------------------------------------------------

I added one call (and two constants) to Thrift.Tests.thrift. I'm not quite sure if this was a good idea, since an additional function in the interface may break existing code in other test servers.
                
      was (Author: jensg):
    I added one call (and two constants) to Thrift.Tests.thrift. I'm not quite sure if this was a good idea, since an additional function in the interface may break code.
                  
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1391_exception_content_test_case.zip
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Improved Delphi XE test cases

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment: THRIFT-1391_Improved_Delphi_XE_test_cases_rev2.patch

This patch may conflict with THRIFT-1401. My recommendation is, that we wait with this one and I re-create the patch after THRIFT-1401 has been committed. However, the patch may be useful to fix THRIFT-1408 in the meantime.

                
> Improved Delphi XE test cases
> -----------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_Improved_Delphi_XE_test_cases_rev2.patch
>
>
> Improved TestClient:
> - collects test results and reports errors
> - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
> - exception content test also included (= initial reason for this patch)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment: THRIFT-1391_Delphi_XE_exceptions_test_case.zip

Testcase add-on patch for THRIFT-1366
                
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>            Reporter: Jens Geyer
>         Attachments: THRIFT-1391_Delphi_XE_exceptions_test_case.zip
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Improved Delphi XE test cases

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment: THRIFT-1391_Improved_Delphi_XE_test_cases_rev3.patch

Updated patch 
- against current trunk
- minor modifications
                
> Improved Delphi XE test cases
> -----------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>    Affects Versions: 0.8
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_Improved_Delphi_XE_test_cases_rev3.patch
>
>
> Improved TestClient:
> - collects test results and reports errors
> - added or completed a number of tests, like listTest, mapmapTest, multiExceptionTest and others
> - exception content test also included (= initial reason for this patch)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jens Geyer (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135856#comment-13135856 ] 

Jens Geyer commented on THRIFT-1391:
------------------------------------

> TODO items

Yes, I think I should do that. It is probably a good idea.

                
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_exception_content_test_case_rev1.patch
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1391) Delphi XE Library test case: Exceptions

Posted by "Jens Geyer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer updated THRIFT-1391:
-------------------------------

    Attachment:     (was: THRIFT-1391_exception_content_test_case.zip)
    
> Delphi XE Library test case: Exceptions
> ---------------------------------------
>
>                 Key: THRIFT-1391
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1391
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Delphi - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>         Attachments: THRIFT-1391_exception_content_test_case_rev1.patch
>
>
> Test case to verify correct handling of exceptions. The test client has a number of assertions, which are all expected to be satisfied. If any of the assertions fails or another error occures, something is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira