You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/28 08:31:06 UTC
[GitHub] [doris] freemandealer opened a new pull request, #14641: [fix](Dictionary-codec) heap overflow with in-predicate on nullable columns (#14319)
freemandealer opened a new pull request, #14641:
URL: https://github.com/apache/doris/pull/14641
Losing segmentid info will mess up the _segment_id_to_value_in_dict_flags map in InListPredicate, causing two distinct segments to collide and crash the BE at last.
There are two facts that will lose segmentid info: 1) mistakenly invoke IColumn dummy virtual function instead of the one in derived class 2) ColumnNullable::get_nested_column() does not pass on the segmentid info.
Signed-off-by: freemandealer <fr...@gmail.com>
# Proposed changes
Issue Number: close #14319
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #14641: [fix](Dictionary-codec) heap overflow with in-predicate on nullable columns (#14319)
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #14641:
URL: https://github.com/apache/doris/pull/14641#discussion_r1034242668
##########
be/src/vec/columns/column_nullable.h:
##########
@@ -311,6 +311,15 @@ class ColumnNullable final : public COWHelper<IColumn, ColumnNullable> {
void sort_column(const ColumnSorter* sorter, EqualFlags& flags, IColumn::Permutation& perms,
EqualRange& range, bool last_column) const override;
+ void set_rowset_segment_id(std::pair<RowsetId, uint32_t> rowset_segment_id) override {
+ Base::set_rowset_segment_id(rowset_segment_id);
Review Comment:
`Base::set_rowset_segment_id(rowset_segment_id);`
Maybe we can remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #14641: [fix](Dictionary-codec) heap overflow with in-predicate on nullable columns (#14319)
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #14641:
URL: https://github.com/apache/doris/pull/14641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14641: [fix](Dictionary-codec) heap overflow with in-predicate on nullable columns (#14319)
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14641:
URL: https://github.com/apache/doris/pull/14641#issuecomment-1328889128
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.75 seconds
load time: 429 seconds
storage size: 17122759909 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221128110304_clickbench_pr_54365.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #14641: [fix](Dictionary-codec) heap overflow with in-predicate on nullable columns (#14319)
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #14641:
URL: https://github.com/apache/doris/pull/14641#issuecomment-1345494339
need merge this to 1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14641: [fix](Dictionary-codec) heap overflow with in-predicate on nullable columns (#14319)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14641:
URL: https://github.com/apache/doris/pull/14641#issuecomment-1330304643
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14641: [fix](Dictionary-codec) heap overflow with in-predicate on nullable columns (#14319)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14641:
URL: https://github.com/apache/doris/pull/14641#issuecomment-1330304691
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org