[GitHub] [trafficcontrol] smalenfant commented on a change in pull request #3556: Default unavailable_server_retry_responses

[GitBox <gi...@apache.org>]

smalenfant commented on a change in pull request #3556: Default unavailable_server_retry_responses
URL: https://github.com/apache/trafficcontrol/pull/3556#discussion_r282191814
 
 

 ##########
 File path: traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm
 ##########
 @@ -2617,13 +2617,8 @@ sub parent_dot_config { #fix qstring - should be ignore for quika
 				}
 				$text .= "$parents round_robin=$mso_algorithm qstring=$parent_qstring go_direct=false parent_is_proxy=false";
 
-				if ( $ats_major_version >= 6 && $parent_retry ne "" ) {
-					if ( $unavailable_server_retry_responses ne "" && $unavailable_server_retry_responses =~ /^"(?:\d{3},)+\d{3}"\s*$/) {
 
 Review comment:
   @ocket8888 Would you know what happens if not validated? Traffic Server crash? If so, should have been documented. 
   
   I removed the validation because there was now defaults for all these params. 
   
   What should be the behavior if I add the validation? Add the "503" default and not fail?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services