You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2024/04/02 06:45:10 UTC
(spark) branch master updated: [SPARK-47686][SQL][TESTS] Use `=!=` instead of `!==` in `JoinHintSuite`
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 00162b82fe3c [SPARK-47686][SQL][TESTS] Use `=!=` instead of `!==` in `JoinHintSuite`
00162b82fe3c is described below
commit 00162b82fe3c48e26303394d1a91d026fe8d9b4c
Author: yangjie01 <ya...@baidu.com>
AuthorDate: Mon Apr 1 23:45:00 2024 -0700
[SPARK-47686][SQL][TESTS] Use `=!=` instead of `!==` in `JoinHintSuite`
### What changes were proposed in this pull request?
This pr use `=!=` instead of `!==` in `JoinHintSuite`. `!==` is a deprecated API since 2.0.0, and its test already exists in `DeprecatedAPISuite`.
### Why are the changes needed?
Clean up deprecated API usage.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #45812 from LuciferYang/SPARK-47686.
Authored-by: yangjie01 <ya...@baidu.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala
index 66746263ff90..53e47f428c3a 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/JoinHintSuite.scala
@@ -695,11 +695,11 @@ class JoinHintSuite extends PlanTest with SharedSparkSession with AdaptiveSparkP
val hintAppender = new LogAppender(s"join hint check for equi-join")
withLogAppender(hintAppender, level = Some(Level.WARN)) {
assertBroadcastNLJoin(
- df1.hint("SHUFFLE_HASH").join(df2, $"a1" !== $"b1"), BuildRight)
+ df1.hint("SHUFFLE_HASH").join(df2, $"a1" =!= $"b1"), BuildRight)
}
withLogAppender(hintAppender, level = Some(Level.WARN)) {
assertBroadcastNLJoin(
- df1.join(df2.hint("MERGE"), $"a1" !== $"b1"), BuildRight)
+ df1.join(df2.hint("MERGE"), $"a1" =!= $"b1"), BuildRight)
}
val logs = hintAppender.loggingEvents.map(_.getMessage.getFormattedMessage)
.filter(_.contains("is not supported in the query:"))
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org