You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/09/18 00:38:00 UTC

[jira] [Commented] (IMPALA-7576) Add e default timeout for all e2e tests

    [ https://issues.apache.org/jira/browse/IMPALA-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618327#comment-16618327 ] 

ASF subversion and git services commented on IMPALA-7576:
---------------------------------------------------------

Commit 7eb64a9be7bb06d1c6f2c8fd1805c12cf61d1844 in impala's branch refs/heads/master from [~twmarshall]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=7eb64a9 ]

IMPALA-7576: Add a timeout for all E2E tests

We've been seeing a lot of hangs in tests lately. This can waste
test resources by keeping machines busy, cause loss of coverage when
subsequent tests don't run, and can be difficult to diagnose if its
not clear which test hung.

This patch introduces a timeout of 2 hours for normal builds and 4
hours for slow builds for all tests run under pytest by using the
pytest-timeout plugin.

The timeouts were chosen to be generous to avoid false positives.
In recent runs I examined, the longest running test is
test_decimal_fuzz, which took 63 minutes in a DEBUG build and
162 minutes in an ASAN build.

Testing:
- Ran locally with a reduced timeout and confirmed the test is
  timed out when expected.

Change-Id: I301dd27a9767bfaef2756282014ef457a31956bd
Reviewed-on: http://gerrit.cloudera.org:8080/11447
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Add e default timeout for all e2e tests
> ---------------------------------------
>
>                 Key: IMPALA-7576
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7576
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 3.1.0
>            Reporter: Thomas Tauber-Marshall
>            Assignee: Thomas Tauber-Marshall
>            Priority: Major
>
> We've recently seen a number of hangs in tests. This can waste testing resources, make it difficult to triage if its unclear what test hung, and can cause loss of coverage when following tests don't run.
> We should set a default timeout in pytest for all tests. The timeout can be high to avoid false positives



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org