You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/04/18 13:14:21 UTC
Review Request 66683: Updated address field of new CLI config to
accept URLs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Bugs: MESOS-8025
https://issues.apache.org/jira/browse/MESOS-8025
Repository: mesos
Description
-------
Updated address field of new CLI config to accept URLs.
Diffs
-----
src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b
src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8
Diff: https://reviews.apache.org/r/66683/diff/1/
Testing
-------
Ran `mesos agent list` successfully with config:
```
[master]
address = "http://<address_of_a_remote_mesos_master>.com:5061"
```
On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
Also ran `mesos-cli-tests` successfully.
Thanks,
Armand Grillet
Re: Review Request 66683: Updated address field of new CLI config to
accept URLs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review201547
-----------------------------------------------------------
FAIL: Mesos binaries failed to build.
Reviews applied: `['66683']`
Failed command: `cmake.exe --build . --config Release -- /maxcpucount`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683
Relevant logs:
- [mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683/logs/mesos-binaries-cmake-stdout.log):
```
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\docker\mesos-docker-executor.vcxproj" (default target) (20) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\docker\mesos-docker-executor.vcxproj]
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj" (default target) (26) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj]
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\master\mesos-master.vcxproj" (default target) (35) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\master\mesos-master.vcxproj]
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (21) ->
d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\slave\mesos-agent.vcxproj]
"D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\jemalloc-5.0.1.vcxproj" (default target) (7) ->
(CustomBuild target) ->
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 9009. [D:\DCOS\mesos\3rdparty\jemalloc-5.0.1.vcxproj]
358 Warning(s)
1 Error(s)
Time Elapsed 00:23:20.12
```
- Mesos Reviewbot Windows
On April 18, 2018, 6:14 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 6:14 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address field of new CLI config to accept URLs.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b
> src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8
>
>
> Diff: https://reviews.apache.org/r/66683/diff/2/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address field of new CLI config to
accept URLs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review209257
-----------------------------------------------------------
PASS: Mesos patch 66683 was successfully built and tested.
Reviews applied: `['66683']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2423/mesos-review-66683
- Mesos Reviewbot Windows
On Oct. 5, 2018, 9:59 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2018, 9:59 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address field of new CLI config to accept URLs.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
> src/python/cli_new/lib/cli/util.py 7cec7e49ab3c0926067626f5bd5dbba8bf4f44d7
>
>
> Diff: https://reviews.apache.org/r/66683/diff/4/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review209356
-----------------------------------------------------------
PASS: Mesos patch 66683 was successfully built and tested.
Reviews applied: `['66683']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2438/mesos-review-66683
- Mesos Reviewbot Windows
On Oct. 9, 2018, 5:37 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2018, 5:37 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address sanitization in new CLI to accept DNS names.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
> src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
> src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
>
>
> Diff: https://reviews.apache.org/r/66683/diff/5/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review209358
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Okt. 9, 2018, 12:49 nachm., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated Okt. 9, 2018, 12:49 nachm.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address sanitization in new CLI to accept DNS names.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
> src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
> src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
>
>
> Diff: https://reviews.apache.org/r/66683/diff/7/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review209364
-----------------------------------------------------------
PASS: Mesos patch 66683 was successfully built and tested.
Reviews applied: `['66683']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2439/mesos-review-66683
- Mesos Reviewbot Windows
On Oct. 9, 2018, 12:49 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2018, 12:49 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address sanitization in new CLI to accept DNS names.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
> src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
> src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
>
>
> Diff: https://reviews.apache.org/r/66683/diff/7/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/
-----------------------------------------------------------
(Updated Oct. 9, 2018, 2:49 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Removed `master_address` variable and moved function.
Bugs: MESOS-8025
https://issues.apache.org/jira/browse/MESOS-8025
Repository: mesos
Description
-------
Updated address sanitization in new CLI to accept DNS names.
Diffs (updated)
-----
src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
Diff: https://reviews.apache.org/r/66683/diff/7/
Changes: https://reviews.apache.org/r/66683/diff/6-7/
Testing
-------
Ran `mesos agent list` successfully with config:
```
[master]
address = "http://<address_of_a_remote_mesos_master>.com:5061"
```
On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
Also ran `mesos-cli-tests` successfully.
Thanks,
Armand Grillet
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/
-----------------------------------------------------------
(Updated Oct. 9, 2018, 2:16 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Published Kevin's review request.
Bugs: MESOS-8025
https://issues.apache.org/jira/browse/MESOS-8025
Repository: mesos
Description
-------
Updated address sanitization in new CLI to accept DNS names.
Diffs (updated)
-----
src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
Diff: https://reviews.apache.org/r/66683/diff/6/
Changes: https://reviews.apache.org/r/66683/diff/5-6/
Testing
-------
Ran `mesos agent list` successfully with config:
```
[master]
address = "http://<address_of_a_remote_mesos_master>.com:5061"
```
On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
Also ran `mesos-cli-tests` successfully.
Thanks,
Armand Grillet
Re: Review Request 66683: Updated address sanitization in new CLI to
accept DNS names.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/
-----------------------------------------------------------
(Updated Oct. 9, 2018, 11:37 a.m.)
Review request for mesos and Kevin Klues.
Summary (updated)
-----------------
Updated address sanitization in new CLI to accept DNS names.
Bugs: MESOS-8025
https://issues.apache.org/jira/browse/MESOS-8025
Repository: mesos
Description (updated)
-------
Updated address sanitization in new CLI to accept DNS names.
Diffs (updated)
-----
src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf
src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
src/python/cli_new/lib/cli/util.py e79268d57bc9be4514e8f087060ea971e9b09c3a
Diff: https://reviews.apache.org/r/66683/diff/5/
Changes: https://reviews.apache.org/r/66683/diff/4-5/
Testing
-------
Ran `mesos agent list` successfully with config:
```
[master]
address = "http://<address_of_a_remote_mesos_master>.com:5061"
```
On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
Also ran `mesos-cli-tests` successfully.
Thanks,
Armand Grillet
Re: Review Request 66683: Updated address field of new CLI config to
accept URLs.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/
-----------------------------------------------------------
(Updated Oct. 5, 2018, 11:59 a.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Rebased.
Bugs: MESOS-8025
https://issues.apache.org/jira/browse/MESOS-8025
Repository: mesos
Description
-------
Updated address field of new CLI config to accept URLs.
Diffs (updated)
-----
src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db
src/python/cli_new/lib/cli/util.py 7cec7e49ab3c0926067626f5bd5dbba8bf4f44d7
Diff: https://reviews.apache.org/r/66683/diff/4/
Changes: https://reviews.apache.org/r/66683/diff/3-4/
Testing
-------
Ran `mesos agent list` successfully with config:
```
[master]
address = "http://<address_of_a_remote_mesos_master>.com:5061"
```
On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
Also ran `mesos-cli-tests` successfully.
Thanks,
Armand Grillet
Re: Review Request 66683: Updated address field of new CLI config to
accept URLs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review201422
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['66683']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683
Relevant logs:
- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683/logs/libprocess-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(499): warning C4244: '=': conversion from 'int64_t' to 'long', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(504): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(185): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(230): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(587): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(598): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(654): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(656): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(675): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(755): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(763): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(874): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1275): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1456): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evdns.c(3792): warning C4996: 'GetVersion': was declared deprecated [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
"D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target) (16) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\3rdparty\libprocess\src\memory_profiler.cpp(316): error C2280: 'Try<std::string,Error> os::shell<>(const std::string &)': attempting to reference a deleted function [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\libprocess\src\memory_profiler.cpp(1105): error C2039: 'write': is not a member of 'os' [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\libprocess\src\memory_profiler.cpp(1105): error C2660: 'write': function does not take 2 arguments [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\libprocess\src\memory_profiler.cpp(1105): error C2512: 'Try<Nothing,Error>': no appropriate default constructor available [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
112 Warning(s)
4 Error(s)
Time Elapsed 00:05:00.42
```
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683/logs/mesos-tests-cmake-stdout.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target) (9) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\3rdparty\libprocess\src\memory_profiler.cpp(316): error C2280: 'Try<std::string,Error> os::shell<>(const std::string &)': attempting to reference a deleted function [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\libprocess\src\memory_profiler.cpp(1105): error C2039: 'write': is not a member of 'os' [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\libprocess\src\memory_profiler.cpp(1105): error C2660: 'write': function does not take 2 arguments [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
d:\dcos\mesos\mesos\3rdparty\libprocess\src\memory_profiler.cpp(1105): error C2512: 'Try<Nothing,Error>': no appropriate default constructor available [D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj]
172 Warning(s)
4 Error(s)
Time Elapsed 00:06:01.54
```
- Mesos Reviewbot Windows
On April 18, 2018, 1:14 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 1:14 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address field of new CLI config to accept URLs.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b
> src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8
>
>
> Diff: https://reviews.apache.org/r/66683/diff/1/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address field of new CLI config to
accept URLs.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review202123
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66683]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 18, 2018, 3:14 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 3:14 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address field of new CLI config to accept URLs.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b
> src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8
>
>
> Diff: https://reviews.apache.org/r/66683/diff/3/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address field of new CLI config to
accept URLs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review202115
-----------------------------------------------------------
PASS: Mesos patch 66683 was successfully built and tested.
Reviews applied: `['66683']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683
- Mesos Reviewbot Windows
On April 18, 2018, 1:14 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 1:14 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address field of new CLI config to accept URLs.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b
> src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8
>
>
> Diff: https://reviews.apache.org/r/66683/diff/3/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address field of new CLI config to
accept URLs.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review201439
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66683]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 18, 2018, 6:14 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 6:14 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address field of new CLI config to accept URLs.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b
> src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8
>
>
> Diff: https://reviews.apache.org/r/66683/diff/1/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 66683: Updated address field of new CLI config to
accept URLs.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66683/#review201590
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66683]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 18, 2018, 6:14 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66683/
> -----------------------------------------------------------
>
> (Updated April 18, 2018, 6:14 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-8025
> https://issues.apache.org/jira/browse/MESOS-8025
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated address field of new CLI config to accept URLs.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b
> src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8
>
>
> Diff: https://reviews.apache.org/r/66683/diff/2/
>
>
> Testing
> -------
>
> Ran `mesos agent list` successfully with config:
> ```
> [master]
> address = "http://<address_of_a_remote_mesos_master>.com:5061"
> ```
> On the server providing `http://<address_of_a_remote_mesos_master>.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`.
>
> Also ran `mesos-cli-tests` successfully.
>
>
> Thanks,
>
> Armand Grillet
>
>