You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mymeiyi (via GitHub)" <gi...@apache.org> on 2025/12/05 02:53:33 UTC
[PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
mymeiyi opened a new pull request, #58738:
URL: https://github.com/apache/doris/pull/58738
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3615859568
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/94f5204718c2a50a81cc3b58da111699d964fd55_94f5204718c2a50a81cc3b58da111699d964fd55_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/94f5204718c2a50a81cc3b58da111699d964fd55_94f5204718c2a50a81cc3b58da111699d964fd55_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.65% (1707/2143) |
| Line Coverage | 66.41% (29931/45068) |
| Region Coverage | 66.99% (14910/22257) |
| Branch Coverage | 57.36% (7933/13830) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3630340176
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58738_94f5204718c2a50a81cc3b58da111699d964fd55_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58738_94f5204718c2a50a81cc3b58da111699d964fd55_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 72.19% (24728/34254) |
| Line Coverage | 58.91% (259702/440822) |
| Region Coverage | 54.02% (216762/401241) |
| Branch Coverage | 55.35% (92316/166782) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3615763607
run cloudut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3630457108
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58738_94f5204718c2a50a81cc3b58da111699d964fd55_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58738_94f5204718c2a50a81cc3b58da111699d964fd55_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 72.18% (24726/34254) |
| Line Coverage | 58.91% (259676/440822) |
| Region Coverage | 53.95% (216488/401241) |
| Branch Coverage | 55.33% (92279/166782) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi merged PR #58738:
URL: https://github.com/apache/doris/pull/58738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3615239423
# FE UT Coverage Report
Increment line coverage `` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58738_94f5204718c2a50a81cc3b58da111699d964fd55/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58738_94f5204718c2a50a81cc3b58da111699d964fd55/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3615292035
<details>
<summary>TPC-H: <b>Total hot run time: 34619 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 94f5204718c2a50a81cc3b58da111699d964fd55, data reload: false
------ Round 1 ----------------------------------
q1 17456 4997 4919 4919
q2 2017 311 201 201
q3 10154 1327 746 746
q4 10249 912 317 317
q5 7586 2448 2240 2240
q6 185 175 140 140
q7 968 779 644 644
q8 9362 1502 1138 1138
q9 7117 5345 5383 5345
q10 6871 2216 1770 1770
q11 534 328 288 288
q12 355 365 225 225
q13 17789 3663 3016 3016
q14 229 240 218 218
q15 603 521 504 504
q16 904 881 800 800
q17 676 809 586 586
q18 7461 7168 7121 7121
q19 1093 984 649 649
q20 380 366 226 226
q21 4045 3602 2560 2560
q22 1019 1023 966 966
Total cold run time: 107053 ms
Total hot run time: 34619 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4939 4935 4907 4907
q2 326 404 308 308
q3 2130 2644 2287 2287
q4 1323 1776 1303 1303
q5 4258 4537 4646 4537
q6 232 181 143 143
q7 2080 1941 1833 1833
q8 2752 2485 2475 2475
q9 7620 7460 7648 7460
q10 3130 3262 2787 2787
q11 601 516 494 494
q12 722 759 610 610
q13 3762 3820 3186 3186
q14 294 335 267 267
q15 557 517 509 509
q16 900 934 877 877
q17 1218 1380 1499 1380
q18 7987 7783 7591 7591
q19 902 883 883 883
q20 1943 2075 1838 1838
q21 4630 4230 4208 4208
q22 1085 1038 983 983
Total cold run time: 53391 ms
Total hot run time: 50866 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3615102461
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3624221245
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3615102883
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3615317995
<details>
<summary>ClickBench: <b>Total hot run time: 28.33 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 94f5204718c2a50a81cc3b58da111699d964fd55, data reload: false
query1 0.06 0.05 0.04
query2 0.14 0.07 0.07
query3 0.33 0.07 0.08
query4 1.60 0.10 0.10
query5 0.26 0.25 0.24
query6 1.18 0.64 0.63
query7 0.03 0.02 0.02
query8 0.08 0.06 0.06
query9 0.58 0.51 0.49
query10 0.55 0.56 0.56
query11 0.26 0.13 0.14
query12 0.25 0.18 0.14
query13 0.65 0.63 0.62
query14 1.01 1.00 0.99
query15 0.88 0.82 0.82
query16 0.39 0.38 0.38
query17 1.02 0.98 1.03
query18 0.24 0.22 0.21
query19 1.90 1.76 1.80
query20 0.02 0.01 0.02
query21 15.43 0.27 0.24
query22 4.97 0.10 0.10
query23 15.40 0.40 0.22
query24 2.49 0.46 0.31
query25 0.10 0.09 0.09
query26 0.18 0.17 0.17
query27 0.09 0.10 0.09
query28 3.74 1.36 1.17
query29 12.62 4.07 3.33
query30 0.33 0.13 0.11
query31 2.81 0.66 0.43
query32 3.24 0.60 0.50
query33 3.10 3.10 3.07
query34 16.83 5.25 4.63
query35 4.71 4.57 4.67
query36 0.61 0.50 0.49
query37 0.24 0.09 0.08
query38 0.20 0.05 0.05
query39 0.07 0.05 0.04
query40 0.20 0.17 0.16
query41 0.13 0.06 0.06
query42 0.08 0.05 0.05
query43 0.06 0.05 0.05
Total cold run time: 99.06 s
Total hot run time: 28.33 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3615309693
<details>
<summary>TPC-DS: <b>Total hot run time: 180403 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 94f5204718c2a50a81cc3b58da111699d964fd55, data reload: false
query5 4823 647 511 511
query6 351 223 207 207
query7 4662 480 283 283
query8 312 258 243 243
query9 8749 2669 2665 2665
query10 548 327 283 283
query11 15250 14689 14525 14525
query12 185 121 114 114
query13 1694 475 375 375
query14 6197 3308 3058 3058
query14_1 2942 2947 3001 2947
query15 213 199 181 181
query16 7431 502 477 477
query17 1223 747 610 610
query18 2019 441 337 337
query19 233 196 168 168
query20 138 120 123 120
query21 219 136 118 118
query22 4079 4176 4067 4067
query23 16578 16320 16021 16021
query23_1 16223 16123 15961 15961
query24 7137 1647 1246 1246
query24_1 1230 1214 1196 1196
query25 660 510 459 459
query26 1262 294 174 174
query27 2881 468 333 333
query28 4378 2179 2171 2171
query29 859 594 492 492
query30 319 244 214 214
query31 837 725 640 640
query32 81 69 68 68
query33 669 349 287 287
query34 867 898 567 567
query35 799 829 753 753
query36 888 929 828 828
query37 125 95 76 76
query38 3854 3894 3766 3766
query39 726 737 739 737
query39_1 698 706 706 706
query40 228 130 119 119
query41 66 61 61 61
query42 129 100 98 98
query43 434 416 398 398
query44 1322 772 767 767
query45 201 193 183 183
query46 907 982 593 593
query47 1682 1724 1647 1647
query48 406 325 242 242
query49 770 438 365 365
query50 687 297 236 236
query51 3841 3868 4014 3868
query52 114 100 85 85
query53 236 235 182 182
query54 316 261 232 232
query55 102 82 78 78
query56 334 320 299 299
query57 1190 1145 1109 1109
query58 303 265 249 249
query59 2382 2370 2295 2295
query60 358 325 302 302
query61 204 167 168 167
query62 788 698 666 666
query63 241 175 183 175
query64 4536 1196 906 906
query65 4046 3955 3993 3955
query66 1244 441 342 342
query67 15248 14980 14954 14954
query68 8248 932 663 663
query69 520 291 264 264
query70 1137 982 989 982
query71 436 297 263 263
query72 6025 4853 4900 4853
query73 699 560 302 302
query74 8493 8905 8638 8638
query75 3109 3028 2517 2517
query76 3385 1135 738 738
query77 557 404 293 293
query78 9618 9675 8874 8874
query79 1701 862 587 587
query80 705 559 457 457
query81 523 269 253 253
query82 202 125 104 104
query83 274 277 254 254
query84 268 116 93 93
query85 960 491 453 453
query86 381 295 288 288
query87 3993 4057 3954 3954
query88 2960 2165 2148 2148
query89 393 325 287 287
query90 1912 158 149 149
query91 171 166 142 142
query92 74 68 67 67
query93 1187 1063 691 691
query94 724 303 268 268
query95 567 339 329 329
query96 539 483 216 216
query97 2579 2644 2583 2583
query98 235 194 206 194
query99 1333 1317 1234 1234
Total cold run time: 268518 ms
Total hot run time: 180403 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3615739232
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/58738_94f5204718c2a50a81cc3b58da111699d964fd55_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/58738_94f5204718c2a50a81cc3b58da111699d964fd55_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 72.19% (24728/34254) |
| Line Coverage | 58.91% (259702/440822) |
| Region Coverage | 54.02% (216762/401241) |
| Branch Coverage | 55.35% (92316/166782) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3615435207
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/94f5204718c2a50a81cc3b58da111699d964fd55_94f5204718c2a50a81cc3b58da111699d964fd55/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/94f5204718c2a50a81cc3b58da111699d964fd55_94f5204718c2a50a81cc3b58da111699d964fd55/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.34% (18634/34932) |
| Line Coverage | 39.02% (172141/441201) |
| Region Coverage | 33.64% (133351/396421) |
| Branch Coverage | 34.58% (57367/165883) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](snapshot) commit snapshot record image_file_size and snapshot_data_size [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58738:
URL: https://github.com/apache/doris/pull/58738#issuecomment-3624221315
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org