[GitHub] [guacamole-client] Vict0rC removed a comment on issue #481: GUACAMOLE-781: Translation updated based on latest en.json and filename fixed to cs.json

[GitBox <gi...@apache.org>]

Vict0rC removed a comment on issue #481: GUACAMOLE-781: Translation updated based on latest en.json and filename fixed to cs.json
URL: https://github.com/apache/guacamole-client/pull/481#issuecomment-600246483
 
 
   > 
   > 
   > A couple things:
   > 
   >     1. Please rebase on top of `staging/1.2.0` branch. As GUACAMOLE-781 is slated for the 1.2.0 release, these changes should be made relative to the 1.2.0 release branch. I've updated the merge base of this PR manually, but that has resulted in a bunch of merge commits appearing.
   > 
   >     2. Please correct the indentation of `cs.json` to use 4-spaces for each level. Your previous `cz.json` followed this, which is great, but git isn't recognizing these changes as a simple update+rename due to each line having different spacing. It should be able to automatically recognize the new `cs.json` as a renamed `cz.json` and show which additional lines were modified.
   > 
   > 
   > I already create a PR for just the basic rename (#480), but I don't mind setting that aside in favor of these changes.
   
   is it ok now?
   https://github.com/apache/guacamole-client/pull/483

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services