You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/20 13:59:52 UTC
[GitHub] [spark] AlessandroPatti opened a new pull request #30104: Fix tests failing with rounding errors
AlessandroPatti opened a new pull request #30104:
URL: https://github.com/apache/spark/pull/30104
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Increase tolerance for two tests the fail in some environments and fail in others (flaky? Pass/fail is constant within the same environment)
### Why are the changes needed?
The tests `pyspark.ml.recommendation` and `pyspark.ml.tests.test_algorithms` fail with
```
File "/home/jenkins/python/pyspark/ml/tests/test_algorithms.py", line 96, in test_raw_and_probability_prediction
self.assertTrue(np.allclose(result.rawPrediction, expected_rawPrediction, atol=1))
AssertionError: False is not true
```
```
File "/home/jenkins/python/pyspark/ml/recommendation.py", line 256, in _main_.ALS
Failed example:
predictions[0]
Expected:
Row(user=0, item=2, newPrediction=0.6929101347923279)
Got:
Row(user=0, item=2, newPrediction=0.6929104924201965)
...
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
This path changes a test target. Just executed the tests to verify they pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712921190
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34656/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30104: [SPARK-33203][PYTHON][TEST] Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30104:
URL: https://github.com/apache/spark/pull/30104
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] WeichenXu123 commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
WeichenXu123 commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712888205
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712936134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712878076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-713221210
@AlessandroPatti, mind filing a JIRA?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712878911
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #30104: [SPARK-33203][PYTHON][TEST] Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-714168133
I know it's very common to have diffs in floats in Python, and to avoid the exact match in doctest but
> some environments
Yeah, It's usually platform and Python version dependent. It should be best to clarify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30104: [SPARK-33203] Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-713591016
The change is pretty fine - what env are you testing on though, just to understand where this might be different?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712936134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712903785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712926977
Looks fine but let me leave it to @WeichenXu123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712903785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30104: [SPARK-33203][PYTHON][TEST] Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-714168133
I know it's very common to have diffs in floats in Python, and to avoid the exact match in doctest but
> some environments
Yeah, It's usually platform and Python version dependent. It should be best clarify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AlessandroPatti commented on pull request #30104: [SPARK-33203] Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
AlessandroPatti commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-713378408
> @AlessandroPatti, mind filing a JIRA?
Sure, filed [SPARK-33203](https://issues.apache.org/jira/browse/SPARK-33203)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712891078
**[Test build #130047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130047/testReport)** for PR 30104 at commit [`7e60ddd`](https://github.com/apache/spark/commit/7e60dddb93d1ec57f177632258abc26fbf7be8d3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712903361
**[Test build #130047 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130047/testReport)** for PR 30104 at commit [`7e60ddd`](https://github.com/apache/spark/commit/7e60dddb93d1ec57f177632258abc26fbf7be8d3).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712878076
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30104: [SPARK-33203][PYTHON][TEST] Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-714124652
Thank you for your first contribution, @AlessandroPatti .
You are added to the Apache Spark contributor group and SPARK-33203 is assigned to you.
Welcome to the Apache Spark community.
Also, I also have the same question with @srowen . Which environment did you hit this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712891078
**[Test build #130047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130047/testReport)** for PR 30104 at commit [`7e60ddd`](https://github.com/apache/spark/commit/7e60dddb93d1ec57f177632258abc26fbf7be8d3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30104: Fix tests failing with rounding errors
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30104:
URL: https://github.com/apache/spark/pull/30104#issuecomment-712936095
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34656/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org