You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhanggougou (via GitHub)" <gi...@apache.org> on 2024/01/05 07:25:36 UTC
[PR] [Fix] Fix clickhouse local generate file has <0x00> (#6089) [seatunnel]
zhanggougou opened a new pull request, #6136:
URL: https://github.com/apache/seatunnel/pull/6136
### Purpose of this pull request
fix clickhouse local generate file has <0x00>,it will cause
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
after fix,i success transfer 300KW records from hive to ck
### Check list
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Fix clickhouse local generate file has <0x00> (#6089) [seatunnel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6136:
URL: https://github.com/apache/seatunnel/pull/6136#issuecomment-3094958177
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Fix clickhouse local generate file has <0x00> (#6089) [seatunnel]
Posted by "zhanggougou (via GitHub)" <gi...@apache.org>.
zhanggougou commented on PR #6136:
URL: https://github.com/apache/seatunnel/pull/6136#issuecomment-1886526591
> Can you add e2e to test this pr?
sorry,i am a newcomer in this project,e2e means?
now,i suspect if this is a bug,give me some time,i will transfer data again to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Fix clickhouse local generate file has <0x00> (#6089) [seatunnel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6136:
URL: https://github.com/apache/seatunnel/pull/6136#issuecomment-3066304333
This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Fix clickhouse local generate file has <0x00> (#6089) [seatunnel]
Posted by "zhanggougou (via GitHub)" <gi...@apache.org>.
zhanggougou closed pull request #6136: [Fix] Fix clickhouse local generate file has <0x00> (#6089)
URL: https://github.com/apache/seatunnel/pull/6136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Fix clickhouse local generate file has <0x00> (#6089) [seatunnel]
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #6136:
URL: https://github.com/apache/seatunnel/pull/6136#issuecomment-1880745412
Can you add e2e to test this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Fix clickhouse local generate file has <0x00> (#6089) [seatunnel]
Posted by "zhanggougou (via GitHub)" <gi...@apache.org>.
zhanggougou commented on PR #6136:
URL: https://github.com/apache/seatunnel/pull/6136#issuecomment-1879626994
> Hi @zhanggougou , thanks for contribute this. Could you explain the reason of change?
you can see this issue https://github.com/apache/seatunnel/issues/6089
when 【buffer.position() + byteData.length > buffer.capacity()】,a new MappedByteBuffer will generate,but last MappedByteBuffer also has some space ,because the bufferSize is fixed
so i compute fileChannel.position,when buffer is not enough,the next will continue previous position,so the local_data will not contains unnecessary <0x00>
Is my problem?but when i fixed it,i succesed transfer data 【OR higher version ck local can ignore <0x00>?】
Looking forward to your reply,thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix] Fix clickhouse local generate file has <0x00> (#6089) [seatunnel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #6136: [Fix] Fix clickhouse local generate file has <0x00> (#6089)
URL: https://github.com/apache/seatunnel/pull/6136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org