You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by gg...@apache.org on 2003/07/19 05:25:39 UTC

cvs commit: jakarta-commons/lang/src/java/org/apache/commons/lang/builder CompareToBuilder.java

ggregory    2003/07/18 20:25:39

  Modified:    lang/src/java/org/apache/commons/lang/builder
                        CompareToBuilder.java
  Log:
  Severity	Description	Resource	In Folder	Location	Creation Time
  	The static method setAccessible(AccessibleObject[], boolean) from the type AccessibleObject should be accessed directly 	CompareToBuilder.java	Apache Jakarta Commons/lang/src/java/org/apache/commons/lang/builder	line 254	July 18, 2003 7:11:22 PM
  
  Revision  Changes    Path
  1.17      +7 -6      jakarta-commons/lang/src/java/org/apache/commons/lang/builder/CompareToBuilder.java
  
  Index: CompareToBuilder.java
  ===================================================================
  RCS file: /home/cvs/jakarta-commons/lang/src/java/org/apache/commons/lang/builder/CompareToBuilder.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- CompareToBuilder.java	14 Jul 2003 22:25:03 -0000	1.16
  +++ CompareToBuilder.java	19 Jul 2003 03:25:38 -0000	1.17
  @@ -53,6 +53,7 @@
    */
   package org.apache.commons.lang.builder;
   
  +import java.lang.reflect.AccessibleObject;
   import java.lang.reflect.Field;
   import java.lang.reflect.Modifier;
   import java.util.Comparator;
  @@ -91,7 +92,7 @@
    *
    * <p>Alternatively, there is a method that uses reflection to determine
    * the fields to test. Because these fields are usually private, the method,
  - * <code>reflectionCompare</code>, uses <code>Field.setAccessible</code> to change
  + * <code>reflectionCompare</code>, uses <code>AccessibleObject.setAccessible</code> to change
    * the visibility of the fields. This will fail under a security manager,
    * unless the appropriate permissions are set. It is also slower than testing
    * explicitly.</p>
  @@ -134,7 +135,7 @@
        * <p>This method uses reflection to determine the ordering between two
        * Objects.</p>
        *
  -     * <p>It uses <code>Field.setAccessible</code> to gain access to private
  +     * <p>It uses <code>AccessibleObject.setAccessible</code> to gain access to private
        * fields. This means that it will throw a security exception if run under
        * a security manger, if the permissions are not set up correctly. It is
        * also not as efficient as testing explicitly.</p>
  @@ -161,7 +162,7 @@
        * <p>This method uses reflection to determine if the two Objects are
        * equal.</p>
        *
  -     * <p>It uses <code>Field.setAccessible</code> to gain access to private
  +     * <p>It uses <code>AccessibleObject.setAccessible</code> to gain access to private
        * fields. This means that it will throw a security exception if run under
        * a security manger, if  the permissions are not set up correctly. It is
        * also not as efficient as testing explicitly.</p>
  @@ -190,7 +191,7 @@
        * <p>This method uses reflection to determine if the two Objects are
        * equal.</p>
        *
  -     * <p>It uses <code>Field.setAccessible</code> to gain access to private
  +     * <p>It uses <code>AccessibleObject.setAccessible</code> to gain access to private
        * fields. This means that it will throw a security exception if run under
        * a security manger, if  the permissions are not set up correctly. It is
        * also not as efficient as testing explicitly.</p>
  @@ -251,7 +252,7 @@
           CompareToBuilder builder,
           boolean useTransients) {
           Field[] fields = clazz.getDeclaredFields();
  -        Field.setAccessible(fields, true);
  +        AccessibleObject.setAccessible(fields, true);
           for (int i = 0; i < fields.length && builder.comparison == 0; i++) {
               Field f = fields[i];
               if ((f.getName().indexOf('$') == -1)
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org