You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by ca...@apache.org on 2008/10/09 23:24:35 UTC

svn commit: r703263 - in /logging/log4j/trunk/src: changes/changes.xml main/java/org/apache/log4j/net/SMTPAppender.java

Author: carnold
Date: Thu Oct  9 14:24:34 2008
New Revision: 703263

URL: http://svn.apache.org/viewvc?rev=703263&view=rev
Log:
Bug 45980: SMTPAppender should have a sendOnClose option

Modified:
    logging/log4j/trunk/src/changes/changes.xml
    logging/log4j/trunk/src/main/java/org/apache/log4j/net/SMTPAppender.java

Modified: logging/log4j/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/logging/log4j/trunk/src/changes/changes.xml?rev=703263&r1=703262&r2=703263&view=diff
==============================================================================
--- logging/log4j/trunk/src/changes/changes.xml (original)
+++ logging/log4j/trunk/src/changes/changes.xml Thu Oct  9 14:24:34 2008
@@ -64,6 +64,7 @@
        <action action="fix" issue="45721">Add configuration of ThrowableRenderers and add org.apache.log4j.EnhancedThrowableRenderer.</action>
        <action action="fix" issue="45969">SMTPAppender does not force evaluation of message at request time</action>
        <action action="fix" issue="25355">Support SSL transport in SMTPAppender</action>
+       <action action="fix" issue="45980">SMTPAppender should have a sendOnClose option</action>
     </release>
 
   

Modified: logging/log4j/trunk/src/main/java/org/apache/log4j/net/SMTPAppender.java
URL: http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/net/SMTPAppender.java?rev=703263&r1=703262&r2=703263&view=diff
==============================================================================
--- logging/log4j/trunk/src/main/java/org/apache/log4j/net/SMTPAppender.java (original)
+++ logging/log4j/trunk/src/main/java/org/apache/log4j/net/SMTPAppender.java Thu Oct  9 14:24:34 2008
@@ -92,6 +92,7 @@
   private boolean smtpDebug = false;
   private int bufferSize = 512;
   private boolean locationInfo = false;
+  private boolean sendOnClose = false;
 
   protected CyclicBuffer cb = new CyclicBuffer(bufferSize);
   protected Message msg;
@@ -270,6 +271,9 @@
   public
   void close() {
     this.closed = true;
+    if (sendOnClose) {
+        sendBuffer();
+    }
   }
 
   InternetAddress getAddress(String addressStr) {
@@ -666,6 +670,25 @@
         smtpPort = val;
   }
 
+    /**
+     * Get sendOnClose.
+     *
+     * @return if true all buffered logging events will be sent when the appender is closed.
+     * @since 1.2.16
+     */
+  public final boolean getSendOnClose() {
+        return sendOnClose;
+  }
+
+    /**
+     * Set sendOnClose.
+     *
+     * @param val if true all buffered logging events will be sent when appender is closed.
+     * @since 1.2.16
+     */
+  public final void setSendOnClose(final boolean val) {
+        sendOnClose = val;
+  }
 
 }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org