You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2018/01/04 09:19:56 UTC

[jclouds/jclouds] JCLOUDS-1368: Simplify slicing algorithm (#1166)

Previously `MultipartUploadSlicingAlgorithm` sliced larger payloads into
a number of fixed-sized parts and a single variable-sized last part.
Callers did not account for the last part which lead to exceeding the
maximum number of parts in `BaseBlobStore.putMultipartBlob`.  Simplify
the interface by removing the remaining concept and simply split the
parts into even sizes.  This improves performance by eliminating
pathological cases with very large last parts.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1166

-- Commit Summary --

  * JCLOUDS-1368: Simplify slicing algorithm

-- File Changes --

    M blobstore/src/main/java/org/jclouds/blobstore/strategy/internal/MultipartUploadSlicingAlgorithm.java (25)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1166.patch
https://github.com/jclouds/jclouds/pull/1166.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1166

Re: [jclouds/jclouds] JCLOUDS-1368: Correct use of slicing algorithm (#1166)

Posted by Andrew Gaul <no...@github.com>.
I reworked this commit to correct the use of the slicing algorithm.  [JCLOUDS-1369](https://issues.apache.org/jira/browse/JCLOUDS-1369) tracks improving the algorithm itself.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1166#issuecomment-355429840

Re: [jclouds/jclouds] JCLOUDS-1368: Simplify slicing algorithm (#1166)

Posted by Andrew Gaul <no...@github.com>.
Sigh, I'll look at this tomorrow.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1166#issuecomment-355236186

Re: [jclouds/jclouds] JCLOUDS-1368: Correct use of slicing algorithm (#1166)

Posted by Andrew Gaul <no...@github.com>.
@gaul pushed 1 commit.

2d702af  JCLOUDS-1369: improving slicing with many parts


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1166/files/eb0200ffe1f2d48d99ae7d0e7f296bd8c2b1bb06..2d702af421da5d7e0a25f52f286a8e99ce9474e1