You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/07/18 15:07:04 UTC
[GitHub] [cloudstack] wido commented on a change in pull request #3502: Rbd
snapshot rollback
wido commented on a change in pull request #3502: Rbd snapshot rollback
URL: https://github.com/apache/cloudstack/pull/3502#discussion_r304969017
##########
File path: engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
##########
@@ -354,10 +362,9 @@ public boolean revertSnapshot(SnapshotInfo snapshotInfo) {
s_logger.error(errMsg);
- throw new CloudRuntimeException(errMsg);
+ throw new CloudRuntimeException("Failed to revert a volume to a snapshot state");
Review comment:
This seems like a very generic message. Can't we add something like the volume name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services