You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "zrlw (via GitHub)" <gi...@apache.org> on 2025/02/13 08:54:03 UTC
[PR] [3.3] remove dubbo-test-check from dubbo-remoting-api [dubbo]
zrlw opened a new pull request, #15130:
URL: https://github.com/apache/dubbo/pull/15130
## What is the purpose of the change?
try to solve dubbo-samples-configcenter-apollo sample test failure issue which caused by #15107
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [3.3] remove dubbo-test-check from dubbo-remoting-api [dubbo]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15130:
URL: https://github.com/apache/dubbo/pull/15130#issuecomment-2656009889
## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/15130?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 58.82%. Comparing base [(`bc729af`)](https://app.codecov.io/gh/apache/dubbo/commit/bc729afcf02555e65b5e601c908b966fadd8a036?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`892ce89`)](https://app.codecov.io/gh/apache/dubbo/commit/892ce89a53db83bf628437a99d93302ce6901d1d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.3 #15130 +/- ##
============================================
- Coverage 58.83% 58.82% -0.01%
Complexity 12 12
============================================
Files 1883 1883
Lines 86013 86013
Branches 12886 12886
============================================
- Hits 50602 50598 -4
- Misses 29881 29885 +4
Partials 5530 5530
```
| [Flag](https://app.codecov.io/gh/apache/dubbo/pull/15130/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unit-tests](https://app.codecov.io/gh/apache/dubbo/pull/15130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.82% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/15130?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [3.3] Revert "feat:dubbo-remoting-zookeeper-curator5 remove dubbo-test module (#15082)" [dubbo]
Posted by "Stellar1999 (via GitHub)" <gi...@apache.org>.
Stellar1999 commented on PR #15130:
URL: https://github.com/apache/dubbo/pull/15130#issuecomment-2656571041
> `dubbo-samples-configcenter-apollo` at https://github.com/apache/dubbo-samples should be modified before removing dubbo-test module from dubbo-remoting-zookeeper-curator5.
It is unrelated to this PR. The investigation indicates that it is related to recent changes in Apollo. I will fix the CI issue later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [3.3] remove dubbo-test-check from dubbo-remoting-api [dubbo]
Posted by "Stellar1999 (via GitHub)" <gi...@apache.org>.
Stellar1999 commented on PR #15130:
URL: https://github.com/apache/dubbo/pull/15130#issuecomment-2656148171
https://github.com/apache/dubbo/pull/15125 It has already been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [3.3] Revert "feat:dubbo-remoting-zookeeper-curator5 remove dubbo-test module (#15082)" [dubbo]
Posted by "zrlw (via GitHub)" <gi...@apache.org>.
zrlw closed pull request #15130: [3.3] Revert "feat:dubbo-remoting-zookeeper-curator5 remove dubbo-test module (#15082)"
URL: https://github.com/apache/dubbo/pull/15130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [3.3] Revert "feat:dubbo-remoting-zookeeper-curator5 remove dubbo-test module (#15082)" [dubbo]
Posted by "zrlw (via GitHub)" <gi...@apache.org>.
zrlw commented on PR #15130:
URL: https://github.com/apache/dubbo/pull/15130#issuecomment-2656543161
```dubbo-samples-configcenter-apollo``` at https://github.com/apache/dubbo-samples should be modified before removing dubbo-test module from dubbo-remoting-zookeeper-curator5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [3.3] remove dubbo-test-check from dubbo-remoting-api [dubbo]
Posted by "zrlw (via GitHub)" <gi...@apache.org>.
zrlw commented on PR #15130:
URL: https://github.com/apache/dubbo/pull/15130#issuecomment-2656351856
> #15125 It has already been removed.
it's useless because dubbo depends on dubbo-remoting-http12, dubbo-remoting-http3, ... which depend on dubbo-test-check.
so i think #15082 might be reverted, or seperate dubbo-remoting-zookeeper-curator5 from dubbo-remoting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [3.3] Revert "feat:dubbo-remoting-zookeeper-curator5 remove dubbo-test module (#15082)" [dubbo]
Posted by "zrlw (via GitHub)" <gi...@apache.org>.
zrlw commented on PR #15130:
URL: https://github.com/apache/dubbo/pull/15130#issuecomment-2656579041
oops, dubbo-samples-configcenter-apollo testing result is always timeout no matter revert #15107 or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [3.3] Revert "feat:dubbo-remoting-zookeeper-curator5 remove dubbo-test module (#15082)" [dubbo]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on PR #15130:
URL: https://github.com/apache/dubbo/pull/15130#issuecomment-2658192663
Will be fixed in https://github.com/apache/dubbo-samples/pull/1203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org