You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/01 03:19:36 UTC
[GitHub] [apisix] spacewander commented on a change in pull request #3699: docs: added `sidebar` config
spacewander commented on a change in pull request #3699:
URL: https://github.com/apache/apisix/pull/3699#discussion_r584422582
##########
File path: docs/en/latest/architecture-design.md
##########
@@ -678,7 +688,7 @@ For example,
}
```
-+
+-
Review comment:
This should be operator `+`.
##########
File path: docs/en/latest/config.json
##########
@@ -1,4 +1,156 @@
{
"version": 2.3,
- "sidebar": {}
+ "sidebar": [
+ {
+ "type": "doc",
+ "id": "architecture-design"
+ },
+ {
+ "type": "doc",
+ "id": "getting-started"
+ },
+ {
+ "type": "doc",
+ "id": "how-to-build"
+ },
+ {
+ "type": "category",
+ "label": "Plugins",
+ "items": [
+ {
+ "type": "category",
+ "label": "General",
+ "items": [
+ "plugins/batch-requests",
+ "https",
Review comment:
Need to move this out of `plugin`.
##########
File path: docs/zh/latest/config.json
##########
@@ -1,4 +1,148 @@
{
"version": 2.3,
- "sidebar": {}
+ "sidebar": [
+ {
+ "type": "doc",
+ "id": "architecture-design"
+ },
+ {
+ "type": "doc",
+ "id": "how-to-build"
+ },
+ {
+ "type": "category",
+ "label": "Plugins",
+ "items": [
+ {
+ "type": "category",
+ "label": "General",
+ "items": [
+ "plugins/batch-requests",
+ "https",
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org